Replace console.error with reportError (further fixes MithrilJS#2621)

With this change, errors that occur within render() or onmatch() will be reported to the global event handler without interrupting processing. As a result, errors will be forwarded to window.onerror.

Author: kfule

api/mount-redraw.js

@@ -10,7 +10,7 @@ module.exports = function(render, schedule) {
 	function sync() {
 		for (offset = 0; offset < subscriptions.length; offset += 2) {
 			try { render(subscriptions[offset], Vnode(subscriptions[offset + 1]), redraw) }
-			catch (e) { console.error(e) }
+			catch (e) { reportError(e) }
 		}
 		offset = -1
 	}

api/router.js

@@ -74,7 +74,7 @@ module.exports = function($window, mountRedraw) {
 		Object.assign(data.params, $window.history.state)
 
 		function reject(e) {
-			console.error(e)
+			reportError(e)
 			route.set(fallbackRoute, null, {replace: true})
 		}
 

api/tests/test-mountRedraw.js

@@ -10,11 +10,11 @@ var coreRenderer = require("../../render/render")
 var h = require("../../render/hyperscript")
 
 o.spec("mount/redraw", function() {
-	var root, m, throttleMock, consoleMock, $document, errors
-	var realError = console.error
+	var root, m, throttleMock, $document, errors
+	var realError = global.reportError
 	o.beforeEach(function() {
 		var $window = domMock()
-		console.error = consoleMock = o.spy()
+		global.reportError = o.spy()
 		throttleMock = throttleMocker()
 		root = $window.document.body
 		m = mountRedraw(coreRenderer($window), throttleMock.schedule)
@@ -23,11 +23,11 @@ o.spec("mount/redraw", function() {
 	})
 
 	o.afterEach(function() {
-		o(consoleMock.calls.map(function(c) {
+		o(global.reportError.calls.map(function(c) {
 			return c.args[0]
 		})).deepEquals(errors)
 		o(throttleMock.queueLength()).equals(0)
-		console.error = realError
+		global.reportError = realError
 	})
 
 	o("shouldn't error if there are no renderers", function() {

api/tests/test-router.js

@@ -69,6 +69,7 @@ o.spec("route", function() {
 
 				// In case it doesn't get reset
 				var realError = console.error
+				var realReportError = global.reportError
 
 				o.beforeEach(function() {
 					currentTest = nextID++
@@ -92,6 +93,7 @@ o.spec("route", function() {
 					o(throttleMock.queueLength()).equals(0)
 					currentTest = -1 // doesn't match any test
 					console.error = realError
+					global.reportError = realReportError
 				})
 
 				o("throws on invalid `root` DOM node", function() {
@@ -1175,7 +1177,7 @@ o.spec("route", function() {
 					var renderCount = 0
 					var spy = o.spy()
 					var error = new Error("error")
-					var errorSpy = console.error = o.spy()
+					var errorSpy = global.reportError = o.spy()
 
 					var resolver = {
 						onmatch: lock(function() {
@@ -2089,11 +2091,11 @@ o.spec("route", function() {
 					}
 
 					// Errors thrown during redrawing of mounted components are caught in m.mount()
-					// and console.error is called.
-					// Therefore, spy is used to confirm that console.error is not called
+					// and reportError is called.
+					// Therefore, spy is used to confirm that reportError is not called
 					// when it is first mounted.
-					var spy = o.spy(console.error)
-					console.error = spy
+					var spy = o.spy()
+					global.reportError = spy
 
 					$window.location.href = prefix + "/"
 					o(function(){