Error handling

[mattjmorrison]

I just ran into this... I got rate limited and the error message seemed fairly cryptic (since it essentially failed silently)

o = Octokit(auth='token', token="mykey")
repo = o.repos.get(owner="myowner", repo="myrepo")
repo.response # is <class 'octokit.ResponseData'>
repo.response.message # is "API rate limit exceeded for user ID XXXXX"

In my case what ended up happening was that I was trying to do something like

o = Octokit(auth='token', token="mykey")
repo = o.repos.get(owner="myowner", repo="myrepo")
repo.response.name # do something with this...

and I ended up getting an AttributeError

AttributeError: type object 'ResponseData' has no attribute 'name'

I'm not sure exactly what the behavior should be.... I assume there should be some exceptions raised in there when non-successful status codes are encountered... maybe? Thoughts?

[khornberg]

Hey, just seeing this...not sure what happened to my notifications

I was working on a script with this today and wanted to check for a 404

I think raising an exception for a 4xx/5xx would work

Looks like rate limits are 403s with X-RateLimit-blah headers that could be printed