forgot to close zip file

kovidgoyal · kovidgoyal · commit 290b86819311 · 2023-03-14T20:42:36.000+05:30
diff --git a/tools/themes/collection.go b/tools/themes/collection.go
@@ -424,6 +424,7 @@ func fetch_cached(name, url, cache_path string, max_cache_age time.Duration) (st
 	if err != nil {
 		return "", fmt.Errorf("Failed to open downloaded zip file with error: %w", err)
 	}
+	defer r.Close()
 	w := zip.NewWriter(tf2)
 	jm.Etag = resp.Header.Get("ETag")
 	jm.Timestamp = utils.ISO8601Format(time.Now())

Original file line number	Diff line number	Diff line change
`@@ -424,6 +424,7 @@ func fetch_cached(name, url, cache_path string, max_cache_age time.Duration) (st`
`424`	`424`	`if err != nil {`
`425`	`425`	`return "", fmt.Errorf("Failed to open downloaded zip file with error: %w", err)`
`426`	`426`	`}`
	`427`	`+ defer r.Close()`
`427`	`428`	`w := zip.NewWriter(tf2)`
`428`	`429`	`jm.Etag = resp.Header.Get("ETag")`
`429`	`430`	`jm.Timestamp = utils.ISO8601Format(time.Now())`