Skip to content

Commit 999f1e6

Browse files
fix: make JsonConverter classes public (#1694)
* fix: make JsonConverter classes public * chore: remove uneeded pragma warning
1 parent 53b3ee6 commit 999f1e6

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

src/KubernetesClient.Aot/V1PatchJsonConverter.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
namespace k8s.Models
22
{
3-
#pragma warning disable CA1812 // Avoid uninstantiated internal classes
4-
internal sealed class V1PatchJsonConverter : JsonConverter<V1Patch>
5-
#pragma warning restore CA1812 // Avoid uninstantiated internal classes
3+
public sealed class V1PatchJsonConverter : JsonConverter<V1Patch>
64
{
75
public override V1Patch Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
86
{

src/KubernetesClient/Models/IntOrStringJsonConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
namespace k8s.Models
22
{
3-
internal sealed class IntOrStringJsonConverter : JsonConverter<IntOrString>
3+
public sealed class IntOrStringJsonConverter : JsonConverter<IntOrString>
44
{
55
public override IntOrString Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
66
{

src/KubernetesClient/Models/ResourceQuantityJsonConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
namespace k8s.Models
22
{
3-
internal sealed class ResourceQuantityJsonConverter : JsonConverter<ResourceQuantity>
3+
public sealed class ResourceQuantityJsonConverter : JsonConverter<ResourceQuantity>
44
{
55
// https://github.com/kubernetes/apimachinery/blob/4b14f804a0babdcc58e695d72f77ad29f536511e/pkg/api/resource/quantity.go#L683
66
public override ResourceQuantity Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)

src/KubernetesClient/Models/V1PatchJsonConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
namespace k8s.Models
22
{
3-
internal sealed class V1PatchJsonConverter : JsonConverter<V1Patch>
3+
public sealed class V1PatchJsonConverter : JsonConverter<V1Patch>
44
{
55
public override V1Patch Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
66
{

0 commit comments

Comments
 (0)