Skip to content

Conversation

@Gacko
Copy link
Member

@Gacko Gacko commented Dec 4, 2025

/triage accepted
/kind cleanup
/priority backlog
/cc @cpanato @strongjz @tao12345666333
/hold

Copilot AI review requested due to automatic review settings December 4, 2025 14:48
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. area/docs area/helm Issues or PRs related to helm charts approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2025
Copilot finished reviewing on behalf of Gacko December 4, 2025 14:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a version release from v1.14.0 to v1.14.1 for the ingress-nginx controller and updates the Helm chart from v4.14.0 to v4.14.1. The release includes bug fixes, dependency updates, and improvements documented in the changelog, most notably a fix for host/path overlap detection across multiple rules.

Key changes:

  • Updated controller image from v1.14.0 to v1.14.1 with new digest
  • Upgraded kube-webhook-certgen from v1.6.4 to v1.6.5
  • Updated deployment manifests, documentation, and Helm chart configurations

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/e2e-tests.md Auto-generated test documentation with updated line numbers and new test case reference
docs/deploy/index.md Updated deployment URLs to reference v1.14.1 controller version
deploy/static/provider/scw/deploy.yaml Updated version labels and container images for Scaleway provider
deploy/static/provider/oracle/deploy.yaml Updated version labels and container images for Oracle Cloud provider
deploy/static/provider/kind/deploy.yaml Updated version labels and container images for kind provider
deploy/static/provider/exoscale/deploy.yaml Updated version labels and container images for Exoscale provider
deploy/static/provider/do/deploy.yaml Updated version labels and container images for DigitalOcean provider
deploy/static/provider/cloud/deploy.yaml Updated version labels and container images for generic cloud provider
deploy/static/provider/baremetal/deploy.yaml Updated version labels and container images for bare metal deployments
deploy/static/provider/aws/nlb-with-tls-termination/deploy.yaml Updated version labels and container images for AWS NLB with TLS termination
deploy/static/provider/aws/deploy.yaml Updated version labels and container images for AWS provider
charts/ingress-nginx/values.yaml Updated default controller image tag and digests for both standard and chroot variants
charts/ingress-nginx/changelog/helm-chart-4.14.1.md Added changelog entry for Helm chart v4.14.1 release
charts/ingress-nginx/README.md Updated version badges and documentation with v4.14.1 and image digest references
charts/ingress-nginx/Chart.yaml Updated chart version to 4.14.1 and appVersion to 1.14.1
changelog/controller-1.14.1.md Added comprehensive changelog documenting all changes in controller v1.14.1
README.md Added v1.14.1 entry to the version compatibility table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2025
@strongjz
Copy link
Member

strongjz commented Dec 4, 2025

/lgtm
/approve

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Gacko, strongjz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Gacko,cpanato,strongjz,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gacko
Copy link
Member Author

Gacko commented Dec 5, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@Gacko Gacko merged commit e832d04 into kubernetes:release-1.14 Dec 5, 2025
29 of 30 checks passed
@Gacko Gacko deleted the rnmjn branch December 5, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants