From 36bbf53b2ab8eacb33634a55acbdbc0c1048f9f1 Mon Sep 17 00:00:00 2001 From: Divy Singhvi Date: Wed, 24 Sep 2025 21:09:38 +0530 Subject: [PATCH 1/2] Deprecated VirtualBox with warning --- cmd/minikube/cmd/start.go | 13 +++++++------ pkg/minikube/registry/drvs/virtualbox/virtualbox.go | 2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index 020cd198a9c6..1335d634baf8 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -308,7 +308,7 @@ func provisionWithDriver(cmd *cobra.Command, ds registry.DriverState, existing * klog.Errorf("Error autoSetOptions : %v", err) } - virtualBoxMacOS13PlusWarning(driverName) + virtualBoxDeprecationWarning(driverName) hyperkitDeprecationWarning(driverName) validateFlags(cmd, driverName) validateUser(driverName) @@ -402,16 +402,17 @@ func provisionWithDriver(cmd *cobra.Command, ds registry.DriverState, existing * }, nil } -func virtualBoxMacOS13PlusWarning(driverName string) { - if !driver.IsVirtualBox(driverName) || !detect.MacOS13Plus() { +// virtualBoxDeprecationWarning prints a deprecation warning for the virtualbox driver +func virtualBoxDeprecationWarning(driverName string) { + if !driver.IsVirtualBox(driverName) { return } - out.WarningT(`Due to changes in macOS 13+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'. + out.WarningT(`The 'virtualbox' driver is deprecated and will be removed in a future release. + You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'. https://minikube.sigs.k8s.io/docs/drivers/vfkit/ https://minikube.sigs.k8s.io/docs/drivers/qemu/ https://minikube.sigs.k8s.io/docs/drivers/docker/ - For more details on the issue see: https://github.com/kubernetes/minikube/issues/15274 -`) + `) } // hyperkitDeprecationWarning prints a deprecation warning for the hyperkit driver diff --git a/pkg/minikube/registry/drvs/virtualbox/virtualbox.go b/pkg/minikube/registry/drvs/virtualbox/virtualbox.go index edff7849d71d..dda62f3956fb 100644 --- a/pkg/minikube/registry/drvs/virtualbox/virtualbox.go +++ b/pkg/minikube/registry/drvs/virtualbox/virtualbox.go @@ -47,7 +47,7 @@ func init() { Config: configure, Status: status, Default: true, - Priority: registry.Fallback, + Priority: registry.Deprecated, Init: func() drivers.Driver { return virtualbox.NewDriver("", "") }, }) if err != nil { From b128d3d4cdbb5b7aeeced7d5ab95296ac270db89 Mon Sep 17 00:00:00 2001 From: Divy Singhvi Date: Thu, 25 Sep 2025 09:01:10 +0530 Subject: [PATCH 2/2] Removed Hardcoded Driver message and use SupportedDrivers()function instead --- cmd/minikube/cmd/start.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index 1335d634baf8..0dd3df72bd25 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -408,11 +408,7 @@ func virtualBoxDeprecationWarning(driverName string) { return } out.WarningT(`The 'virtualbox' driver is deprecated and will be removed in a future release. - You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'. - https://minikube.sigs.k8s.io/docs/drivers/vfkit/ - https://minikube.sigs.k8s.io/docs/drivers/qemu/ - https://minikube.sigs.k8s.io/docs/drivers/docker/ - `) + You can use alternative drivers: {{.drivers}}.`, out.V{"drivers": strings.Join(driver.SupportedDrivers(), ", ")}) } // hyperkitDeprecationWarning prints a deprecation warning for the hyperkit driver