Chore: Add admissionWebhookTimeout parameter for webhook configurations (#220)

* Chore: Add admissionWebhookTimeout parameter for webhook configurations

Signed-off-by: Amit Singh <[email protected]>

* Chore: Remove default timeoutSeconds value from mutatingWebhookConfiguration

Signed-off-by: Chaitanya Reddy Onteddu <[email protected]>

* Chore: Remove default timeoutSeconds value from validatingWebhookConfiguration

Signed-off-by: Chaitanya Reddy Onteddu <[email protected]>

---------

Signed-off-by: Amit Singh <[email protected]>
Signed-off-by: Chaitanya Reddy Onteddu <[email protected]>
Co-authored-by: Vaibhav Agrawal <[email protected]>

Author: Chaitanyareddy0702

charts/vela-workflow/README.md

@@ -95,6 +95,7 @@ helm install --create-namespace -n vela-system workflow kubevela/vela-workflow -
 | `logDebug`                   | Enable debug logs for development purpose                                                                                  | `false`         |
 | `logFilePath`                | If non-empty, write log files in this path                                                                                 | `""`            |
 | `logFileMaxSize`             | Defines the maximum size a log file can grow to. Unit is megabytes. If the value is 0, the maximum file size is unlimited. | `1024`          |
+| `admissionWebhookTimeout`    | Timeout seconds for admission webhooks                                                                                     | `10`            |
 | `kubeClient.qps`             | The qps for reconcile clients, default is 50                                                                               | `500`           |
 | `kubeClient.burst`           | The burst for reconcile clients, default is 100                                                                            | `1000`          |
 | `kubeClient.userAgent`       | The user agent of the client, default is vela-workflow                                                                     | `vela-workflow` |

charts/vela-workflow/templates/admission-webhooks/mutatingWebhookConfiguration.yaml

@@ -21,6 +21,7 @@ webhooks:
     failurePolicy: Fail
     {{- end }}
     name: mutating.core.oam.dev.v1alpha1.workflowruns
+    timeoutSeconds: {{ .Values.admissionWebhookTimeout }}
     sideEffects: None
     rules:
       - apiGroups:
@@ -36,6 +37,5 @@ webhooks:
     admissionReviewVersions:
       - v1beta1
       - v1
-    timeoutSeconds: 5
 
 {{- end -}}

charts/vela-workflow/templates/admission-webhooks/validatingWebhookConfiguration.yaml

@@ -21,6 +21,7 @@ webhooks:
     failurePolicy: {{ .Values.admissionWebhooks.failurePolicy }}
     {{- end }}
     name: validating.core.oam.dev.v1alpha2.applicationconfigurations
+    timeoutSeconds: {{ .Values.admissionWebhookTimeout }}
     sideEffects: None
     rules:
       - apiGroups:
@@ -36,5 +37,4 @@ webhooks:
     admissionReviewVersions:
       - v1beta1
       - v1
-    timeoutSeconds: 5
 {{- end -}}

charts/vela-workflow/values.yaml

@@ -150,6 +150,9 @@ logFilePath: ""
 ## @param logFileMaxSize Defines the maximum size a log file can grow to. Unit is megabytes. If the value is 0, the maximum file size is unlimited.
 logFileMaxSize: 1024
 
+## @param admissionWebhookTimeout Timeout seconds for admission webhooks
+admissionWebhookTimeout: 10
+
 ## @skip admissionWebhooks
 admissionWebhooks:
   enabled: true