Skip to content

Commit 584f0ae

Browse files
authored
[V1] Make AsyncLLMEngine v1-v0 opaque (vllm-project#11383)
Signed-off-by: Ricky Xu <[email protected]>
1 parent 51ff216 commit 584f0ae

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

vllm/engine/async_llm_engine.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1256,3 +1256,10 @@ async def stop_profile(self) -> None:
12561256
self.engine.model_executor.stop_profile()
12571257
else:
12581258
self.engine.model_executor._run_workers("stop_profile")
1259+
1260+
1261+
# TODO(v1): Remove this class proxy when V1 goes default.
1262+
if envs.VLLM_USE_V1:
1263+
from vllm.v1.engine.async_llm import AsyncLLM
1264+
1265+
AsyncLLMEngine = AsyncLLM # type: ignore

vllm/entrypoints/openai/api_server.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import vllm.envs as envs
2828
from vllm.config import ModelConfig
2929
from vllm.engine.arg_utils import AsyncEngineArgs
30+
from vllm.engine.async_llm_engine import AsyncLLMEngine # type: ignore
3031
from vllm.engine.multiprocessing.client import MQLLMEngineClient
3132
from vllm.engine.multiprocessing.engine import run_mp_engine
3233
from vllm.engine.protocol import EngineClient
@@ -66,11 +67,6 @@
6667
is_valid_ipv6_address)
6768
from vllm.version import __version__ as VLLM_VERSION
6869

69-
if envs.VLLM_USE_V1:
70-
from vllm.v1.engine.async_llm import AsyncLLMEngine # type: ignore
71-
else:
72-
from vllm.engine.async_llm_engine import AsyncLLMEngine # type: ignore
73-
7470
TIMEOUT_KEEP_ALIVE = 5 # seconds
7571

7672
prometheus_multiproc_dir: tempfile.TemporaryDirectory

vllm/v1/engine/async_llm.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def from_engine_args(
9898
start_engine_loop: bool = True,
9999
usage_context: UsageContext = UsageContext.ENGINE_CONTEXT,
100100
stat_loggers: Optional[Dict[str, StatLoggerBase]] = None,
101-
) -> "AsyncLLMEngine":
101+
) -> "AsyncLLM":
102102
"""Create an AsyncLLM from the EngineArgs."""
103103

104104
# Create the engine configs.
@@ -386,7 +386,3 @@ def errored(self) -> bool:
386386
@property
387387
def dead_error(self) -> BaseException:
388388
return Exception() # TODO: implement
389-
390-
391-
# Retain V0 name for backwards compatibility.
392-
AsyncLLMEngine = AsyncLLM

0 commit comments

Comments
 (0)