Rework community module interface

[pPrecel]

The module add command supports passing a community module location using the --origin flag, but still requires an argument that is ignored in this flow. Additionally, module delete doesn't implement the --origin login and still requires the --community flag to remove such a module:

$ ./bin/kyma module delete registry-proxy
Are you sure you want to delete module registry-proxy?
Before you delete the registry-proxy module, make sure the module resources are no longer needed. This action also permanently removes the namespaces, service instances, and service bindings created by the module.
Are you sure you want to continue? [y/N]: y
Error:
  failed to get ModuleTemplate CR for module

Error Details:
  can't find neither ModuleReleaseMeta CR/CRD nor ModuleTemplate CR for module  in channel

TODO

• Rework the module add command to accept passing the community module location through an argument
• Rework the module delete interface to look similar to module add

[anoipm]

QA

The newest version of cli:

$ ./bin/kyma version
Kyma-CLI Version: local-dd385926

$ ./bin/kyma module catalog
NAME                    AVAILABLE VERSIONS                                                 ORIGIN
...
docker-registry         0.10.0                                                             default/docker-registry-0.10.0
registry-proxy          0.14.0                                                             default/registry-proxy-0.14.0
cap-operator            0.20.1                                                             community
docker-registry         0.10.0                                                             community
registry-proxy          0.14.0                                                             community

❓ What do the lines with origin == community mean? Can I install them?

$ ./bin/kyma module add docker-registry --help
Use this command to add a module.

Usage:
  kyma module add <module> [flags]

Examples:
  # Add the Keda module with the default CR
  kyma module add keda --default-cr

  # Add the Keda module with a custom CR from a file
  kyma module add keda --cr-path ./keda-cr.yaml

  ## Add a community module with a default CR and auto-approve the SLA
  #  passed argument must be in the format <namespace>/<module-template-name>
  #  the module must be pulled from the catalog first using the 'kyma module pull' command
  kyma module add my-namespace/my-module-template-name --default-cr --auto-approve

Flags:
...

❗ It's not clear to me that <namespace>/<module-template-name> is the same as origin in module list.

$ ./bin/kyma module add default/registry-proxy-0.14.0
Warning:
  You are about to install a community module.
  Community modules are not officially supported and come with no binding Service Level Agreement (SLA).
  There is no guarantee of support, maintenance, or compatibility.

Are you sure you want to proceed with the installation? [Y/n]: y
registry-proxy-0.14.0 community module enabled

🆗 Installed

$ ./bin/kyma module list
NAME             VERSION          CR POLICY         MANAGED   MODULE STATUS   INSTALLATION STATUS
...
registry-proxy   0.14.0           N/A               false     Unknown         Ready

🆗 Is on the list.

$ ./bin/kyma module delete registry-proxy
Are you sure you want to delete module registry-proxy?
Before you delete the registry-proxy module, make sure the module resources are no longer needed. This action also permanently removes the namespaces, service instances, and service bindings created by the module.
Are you sure you want to continue? [y/N]: y
Error:
  failed to get ModuleTemplate CR for module

Error Details:
  can't find neither ModuleReleaseMeta CR/CRD nor ModuleTemplate CR for module  in channel

❗ Why? I got the module name from module list. How can I guess that I should use origin from module catalog?

$ ./bin/kyma module delete default/registry-proxy-0.14.0
removing registry-proxy community module from the target Kyma environment
failed to delete resource default (RegistryProxy): failed to watch resource default: failed to discover API resource using discovery client: resource 'RegistryProxy' in group 'operator.kyma-project.io', and version 'v1alpha1' not registered on cluster
waiting for resource deletion: registry-proxy-operator (Deployment)
waiting for resource deletion: registry-proxy-operator-metrics-service (Service)
waiting for resource deletion: registry-proxy-operator-leader-election-rolebinding (RoleBinding)
waiting for resource deletion: registry-proxy-operator-leader-election-role (Role)
waiting for resource deletion: registry-proxy-operator-rolebinding (ClusterRoleBinding)
waiting for resource deletion: registry-proxy-operator-metrics-auth-rolebinding (ClusterRoleBinding)
waiting for resource deletion: registry-proxy-operator-role (ClusterRole)
waiting for resource deletion: registry-proxy-operator-metrics-reader (ClusterRole)
waiting for resource deletion: registry-proxy-operator-metrics-auth-role (ClusterRole)
waiting for resource deletion: registry-proxy-operator-viewer-role (ClusterRole)
waiting for resource deletion: registry-proxy-operator-editor-role (ClusterRole)
waiting for resource deletion: registry-proxy-operator-admin-role (ClusterRole)
failed to delete resource registryproxies.operator.kyma-project.io (CustomResourceDefinition): failed to remove resource registryproxies.operator.kyma-project.io: failed to delete cluster-scoped resource customresourcedefinitions.apiextensions.k8s.io "registryproxies.operator.kyma-project.io" not found
waiting for resource deletion: registry-proxy-operator.kyma-project.io (ConfigMap)
waiting for resource deletion: registry-proxy-operator (ServiceAccount)
waiting for resource deletion: registry-proxy (Namespace)
some errors occured during the registry-proxy community module removal

❓ Why I have such error?

$ ./bin/kyma module list
NAME           VERSION          CR POLICY         MANAGED   MODULE STATUS   INSTALLATION STATUS
api-gateway    3.4.0(fast)      CreateAndDelete   true      Ready           Ready
btp-operator   1.2.22(fast)     CreateAndDelete   true      Ready           Ready
istio          1.23.1(fast)     CreateAndDelete   true      Ready           Ready
serverless     1.8.4(regular)   CreateAndDelete   true      Deleting        Deleting

🆗 It isn't on the list.