Skip to content

Conversation

@JoshuaWatt
Copy link
Contributor

Adds an attribute that controls if the driver fully manages the network interface, which causes it to setup and teardown the interface on activate and deactivate. This allows users to disable this behavior if they are externally managing the interface.

Closes: #1728

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • Add a section on how to use the feature to doc/usage.rst
  • Add a section on how to use the feature to doc/development.rst
  • PR has been tested

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.4%. Comparing base (e9e43aa) to head (fe4ec8b).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/driver/rawnetworkinterfacedriver.py 14.2% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1737     +/-   ##
========================================
- Coverage    45.4%   45.4%   -0.1%     
========================================
  Files         172     172             
  Lines       13500   13503      +3     
========================================
+ Hits         6130    6131      +1     
- Misses       7370    7372      +2     
Flag Coverage Δ
3.10 45.4% <14.2%> (-0.1%) ⬇️
3.11 45.4% <14.2%> (-0.1%) ⬇️
3.12 45.4% <14.2%> (-0.1%) ⬇️
3.13 45.3% <14.2%> (-0.1%) ⬇️
3.9 45.4% <14.2%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Adds an attribute that controls if the driver fully manages the
network interface, which causes it to setup and teardown the interface
on activate and deactivate. This allows users to disable this behavior
if they are externally managing the interface.

Closes: labgrid-project#1728

Signed-off-by: Joshua Watt <[email protected]>
[bst: make documentation more consistent]
Signed-off-by: Bastian Krause <[email protected]>
@Bastian-Krause
Copy link
Member

Thanks! I've made the documentation part a bit more consistent.

@Bastian-Krause Bastian-Krause merged commit 29d1fc4 into labgrid-project:master Sep 19, 2025
9 of 11 checks passed
@JoshuaWatt
Copy link
Contributor Author

Thanks @Bastian-Krause. Can we backport this to the stable-25.0 branch also? I can make a PR if that's the easiest

@Bastian-Krause
Copy link
Member

Thanks @Bastian-Krause. Can we backport this to the stable-25.0 branch also? I can make a PR if that's the easiest

I'll backport it.

@Bastian-Krause
Copy link
Member

Thanks @Bastian-Krause. Can we backport this to the stable-25.0 branch also? I can make a PR if that's the easiest

I'll backport it.

Done.

@Bastian-Krause Bastian-Krause added picked to stable Already picked to the latest stable branch. and removed pick to stable Needs a pick to the latest stable branch labels Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

picked to stable Already picked to the latest stable branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RawNetworkInterfaceDriver downs the interface unexpectedly

2 participants