-
Notifications
You must be signed in to change notification settings - Fork 513
feat: add framework of partitioned namespace #5638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c62d87b to
8dce784
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
8dce784 to
51ca004
Compare
|
Hi @jackye1995 , I think may be we can push forward partitioning by first discussing the behavior of After the Looking forward to your thoughts! |
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| #[derive(Debug, Clone, Serialize, Deserialize)] | ||
| pub struct JsonPartitionField { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: since it's a part of the namespace spec, I think we can add this as a part of the OpenAPI definition, so it is codegened and has all the serde aspects handled automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be parallel to dir.rs, not within it, because it's a separated thing, it's dependent on dir.rs but not a sub-part of it.
Hi, I've only recently come across this discussion. Currently, it seems that a partition table is defined as a special type of Directory Namespace. My question is whether partition tables can be extended to also be applicable to REST Namespace Impl, thus adapting to a wider range of scenarios? My question stems from our scenario having a centralized metadata service, where we'd prefer to manage both non-partitioned and partitioned tables uniformly using REST Namespaces. Looking forward to your reply, thanks! |
Hi @xloya , thanks your suggestion. One good feature of partitioned namespace is: it transforms a directory as a partitioned table. It means you can register a partitioned namespace uri to your centralized metadata service, just like normal lance table. Does is work for you? |
Draft
This is based on lance-format/lance-namespace#279
Overview
PartitionedNamespace is an impl of LanceNamespace. It is a kind of DirectoryNamespace, containing a field member in type DirectoryNamespace.
Methods
There are 3 kinds of methods of PartitionedNamespace: