Update README about Laravel version #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the badge will auto renew depend on composer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the badge will auto renew depend on
composer.json.How and why? Every Laravel package should implement and extend the
Illuminate\Support\ServiceProviderwhich include inilluminate/support. The versions of those packages fromilluminatevendor are following the version of Laravel framework. Therefor, we can directly show the version ofilluminate/supportthat incomposer.jsonto indicate supported version in this package.If PR is accepted and you don't mind, could you add a
hacktoberfest-acceptedlabel to help me with hacktoberfest? Thanks!