[13.x] Bind manager instances to custom driver closures (#57173)

* [13.x] Bind manager instances to custom driver closures

* fix test

---------

Co-authored-by: Sergey Danilchenko <[email protected]>

Author: daniser

src/Illuminate/Auth/AuthManager.php

@@ -263,11 +263,14 @@ public function resolveUsersUsing(Closure $userResolver)
      *
      * @param  string  $driver
      * @param  \Closure  $callback
+     *
+     * @param-closure-this  $this  $callback
+     *
      * @return $this
      */
     public function extend($driver, Closure $callback)
     {
-        $this->customCreators[$driver] = $callback;
+        $this->customCreators[$driver] = $callback->bindTo($this, $this);
 
         return $this;
     }

src/Illuminate/Broadcasting/BroadcastManager.php

@@ -476,11 +476,14 @@ public function purge($name = null)
      *
      * @param  string  $driver
      * @param  \Closure  $callback
+     *
+     * @param-closure-this  $this  $callback
+     *
      * @return $this
      */
     public function extend($driver, Closure $callback)
     {
-        $this->customCreators[$driver] = $callback;
+        $this->customCreators[$driver] = $callback->bindTo($this, $this);
 
         return $this;
     }

src/Illuminate/Filesystem/FilesystemManager.php

@@ -430,11 +430,14 @@ public function purge($name = null)
      *
      * @param  string  $driver
      * @param  \Closure  $callback
+     *
+     * @param-closure-this  $this  $callback
+     *
      * @return $this
      */
     public function extend($driver, Closure $callback)
     {
-        $this->customCreators[$driver] = $callback;
+        $this->customCreators[$driver] = $callback->bindTo($this, $this);
 
         return $this;
     }

src/Illuminate/Support/Manager.php

@@ -120,11 +120,14 @@ protected function callCustomCreator($driver)
      *
      * @param  string  $driver
      * @param  \Closure  $callback
+     *
+     * @param-closure-this  $this  $callback
+     *
      * @return $this
      */
     public function extend($driver, Closure $callback)
     {
-        $this->customCreators[$driver] = $callback;
+        $this->customCreators[$driver] = $callback->bindTo($this, $this);
 
         return $this;
     }

tests/Auth/AuthenticateMiddlewareTest.php

@@ -148,6 +148,12 @@ public function testMultipleDriversAuthenticatedUpdatesDefault()
         $this->assertSame($secondary, $this->auth->guard());
     }
 
+    public function testCustomDriverClosureBoundObjectIsAuthManager()
+    {
+        $this->auth->extend(__CLASS__, fn () => $this);
+        $this->assertSame($this->auth, $this->auth->guard(__CLASS__));
+    }
+
     /**
      * Create a new config repository instance.
      *
@@ -161,6 +167,7 @@ protected function createConfig()
                 'guards' => [
                     'default' => ['driver' => 'default'],
                     'secondary' => ['driver' => 'secondary'],
+                    __CLASS__ => ['driver' => __CLASS__],
                 ],
             ],
         ]);

tests/Cache/CacheManagerTest.php

@@ -22,18 +22,17 @@ protected function tearDown(): void
 
     public function testCustomDriverClosureBoundObjectIsCacheManager()
     {
-        $cacheManager = new CacheManager([
-            'config' => [
-                'cache.stores.'.__CLASS__ => [
-                    'driver' => __CLASS__,
+        $manager = new CacheManager($this->getApp([
+            'cache' => [
+                'stores' => [
+                    __CLASS__ => [
+                        'driver' => __CLASS__,
+                    ],
                 ],
             ],
-        ]);
-        $driver = function () {
-            return $this;
-        };
-        $cacheManager->extend(__CLASS__, $driver);
-        $this->assertEquals($cacheManager, $cacheManager->store(__CLASS__));
+        ]));
+        $manager->extend(__CLASS__, fn () => $this);
+        $this->assertSame($manager, $manager->store(__CLASS__));
     }
 
     public function testCustomDriverOverridesInternalDrivers()

tests/Filesystem/FilesystemManagerTest.php

@@ -217,6 +217,19 @@ public function testCanBuildInlineScopedDisks()
         }
     }
 
+    public function testCustomDriverClosureBoundObjectIsFilesystemManager()
+    {
+        $manager = new FilesystemManager(tap(new Application, function ($app) {
+            $app['config'] = [
+                'filesystems.disks.'.__CLASS__ => [
+                    'driver' => __CLASS__,
+                ],
+            ];
+        }));
+        $manager->extend(__CLASS__, fn () => $this);
+        $this->assertSame($manager, $manager->disk(__CLASS__));
+    }
+
     // public function testKeepTrackOfAdapterDecoration()
     // {
     //     try {

tests/Integration/Broadcasting/BroadcastManagerTest.php

@@ -100,6 +100,21 @@ public function testThrowExceptionWhenUnknownStoreIsUsed()
         $broadcastManager->connection('alien_connection');
     }
 
+    public function testCustomDriverClosureBoundObjectIsBroadcastManager()
+    {
+        $manager = new BroadcastManager($this->getApp([
+            'broadcasting' => [
+                'connections' => [
+                    __CLASS__ => [
+                        'driver' => __CLASS__,
+                    ],
+                ],
+            ],
+        ]));
+        $manager->extend(__CLASS__, fn () => $this);
+        $this->assertSame($manager, $manager->connection(__CLASS__));
+    }
+
     protected function getApp(array $userConfig)
     {
         $app = new Container;

tests/Integration/Support/Fixtures/MultipleInstanceManager.php

@@ -89,6 +89,10 @@ public function getInstanceConfig($name)
                     'driver' => 'mysql_database-connection',
                     'mysql_database-connection-option' => 'option-value',
                 ];
+            case 'custom':
+                return [
+                    'driver' => 'custom',
+                ];
             default:
                 return [];
         }

tests/Integration/Support/ManagerTest.php

@@ -14,4 +14,11 @@ public function testDefaultDriverCannotBeNull()
 
         (new NullableManager($this->app))->driver();
     }
+
+    public function testCustomDriverClosureBoundObjectIsManager()
+    {
+        $manager = new NullableManager($this->app);
+        $manager->extend(__CLASS__, fn () => $this);
+        $this->assertSame($manager, $manager->driver(__CLASS__));
+    }
 }