refactor: clean up shouldRun implementation

- Remove unnecessary $shouldRunSeeder variable
- Use continue for early return when seeder is skipped
- Skip adding skipped seeders to $called array (matches migration behavior)
- Add assertions to verify $called array tracking

Author: ManukMinasyan

src/Illuminate/Database/Seeder.php

@@ -49,33 +49,33 @@ public function call($class, $silent = false, array $parameters = [])
 
             $name = get_class($seeder);
 
-            $shouldRunSeeder = $seeder->shouldRun();
-
-            if (! $shouldRunSeeder) {
+            if (! $seeder->shouldRun()) {
                 if ($silent === false && isset($this->command)) {
                     (new TwoColumnDetail($this->command->getOutput()))
                         ->render($name, '<fg=yellow;options=bold>SKIPPED</>');
 
                     $this->command->getOutput()->writeln('');
                 }
-            } else {
-                if ($silent === false && isset($this->command)) {
-                    (new TwoColumnDetail($this->command->getOutput()))
-                        ->render($name, '<fg=yellow;options=bold>RUNNING</>');
-                }
 
-                $startTime = microtime(true);
+                continue;
+            }
 
-                $seeder->__invoke($parameters);
+            if ($silent === false && isset($this->command)) {
+                (new TwoColumnDetail($this->command->getOutput()))
+                    ->render($name, '<fg=yellow;options=bold>RUNNING</>');
+            }
 
-                if ($silent === false && isset($this->command)) {
-                    $runTime = number_format((microtime(true) - $startTime) * 1000);
+            $startTime = microtime(true);
 
-                    (new TwoColumnDetail($this->command->getOutput()))
-                        ->render($name, "<fg=gray>$runTime ms</> <fg=green;options=bold>DONE</>");
+            $seeder->__invoke($parameters);
 
-                    $this->command->getOutput()->writeln('');
-                }
+            if ($silent === false && isset($this->command)) {
+                $runTime = number_format((microtime(true) - $startTime) * 1000);
+
+                (new TwoColumnDetail($this->command->getOutput()))
+                    ->render($name, "<fg=gray>$runTime ms</> <fg=green;options=bold>DONE</>");
+
+                $this->command->getOutput()->writeln('');
             }
 
             static::$called[] = $class;

tests/Database/DatabaseSeederTest.php

@@ -119,6 +119,8 @@ public function testCallSkipsSeederWhenShouldRunReturnsFalse()
         $child->shouldNotReceive('__invoke');
 
         $seeder->call(TestSkippedSeeder::class);
+
+        $this->assertNotContains(TestSkippedSeeder::class, TestSeeder::$called);
     }
 
     public function testCallRunsSeederWhenShouldRunReturnsTrue()
@@ -137,6 +139,8 @@ public function testCallRunsSeederWhenShouldRunReturnsTrue()
         $child->shouldReceive('__invoke')->once();
 
         $seeder->call(TestSeeder::class);
+
+        $this->assertContains(TestSeeder::class, TestSeeder::$called);
     }
 
     public function testCallSilentlySkipsSeederWhenShouldRunReturnsFalse()
@@ -150,5 +154,7 @@ public function testCallSilentlySkipsSeederWhenShouldRunReturnsFalse()
         $child->shouldNotReceive('__invoke');
 
         $seeder->callSilent(TestSkippedSeeder::class);
+
+        $this->assertNotContains(TestSkippedSeeder::class, TestSeeder::$called);
     }
 }