Replacing/Merging inside FormRequest passedValidation doesn't work as intended.

[JesterIruka]

Laravel Version

12.36.1

PHP Version

8.4.13

Database Driver & Version

No database

Description

Inside the FormRequest instance, using $this->replace([]) does not work as intended.
The return value from $request->validated() in the controller is different from what is expected.
Instead, the data remains exactly the same as before calling passedValidation().

This behavior doesn't affect prepareForValidation().

Steps To Reproduce

https://github.com/JesterIruka/laravel-passed-validation-bug

Edit: run php artisan test

[JesterIruka]

Testing other methods, I found out that $request->all() or $request->input() works as intended, but using them that way removes the safeguard against unknown keys that were previously blocked by $request->validated()

[macropay-solutions]

We noticed the replace is not working globally ok so we bypassed it with a macro

Request::macro('forceReplace', function (array $data): Request {
            /** @var Request $this */

            $this->query->replace();
            $this->request->replace();
            $this->replace($data);

            return $this;
        });

[mosabbirrakib]

I've created a fix for this issue in PR #57666.

The problem was that when replace() or merge() methods are called in passedValidation(), the validator instance still held the original data, so validated() returned the old data instead of the modified data.

The fix syncs the validator's data with the current request data after passedValidation() is called, ensuring that any modifications are properly reflected in validated().

[JesterIruka]

I've created a fix for this issue in PR #57666.

Thank you @mosabbirrakib for solving the issue.
I was expecting something like that, the validator holding the original data makes sense.
Unfortunately, Taylor has been rejecting a lot of PRs lately, I can still use prepareForValidation in my scenario, so no worries at the moment.