Cache on Sqlite3 includes NULL character in the value

[adamkiss]

Laravel Version

11.37.0

PHP Version

8.4.2

Database Driver & Version

Sqlite3 3.43.2 2023-10-10 13:08:14

Description

PHP serialize includes a null character when serializing objects with private properties (Source: PHP.net / Serialize), which SQLite3 doesn't properly support - getting cached values with Laravel somehow works, but the cli command sqlite3, many db browsers and even the .dump command fail to properly output the value from the cache KV store (Source: SQLite3 - Nul characters in strings).

When debugging the error with the unserialisation of the value, I've noticed the Cache class already guards against nul values in Postgresql connections in

framework/src/Illuminate/Cache/DatabaseStore.php

Line 490 in 8b93d39

if ($this->connection instanceof PostgresConnection && str_contains($result, "\0")) {

, and I think SqliteConnection has to be guarded the same way.

Steps To Reproduce

1. create new laravel app
2. set cache_store to database
3. cache any object with private properties (I'm caching Collection)
4. observe the database through cli command, db browser, or try to .dump the sqlite file

[github-actions]

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

[adamkiss]

@crynobone i did prepare a pull request, but @taylorotwell closed it on grounds of potential error state which is handled in the PR. What's the way to get the PR reopened?

Edit: nevermind, created a new PR