wip

Author: driesvints

app/Console/Commands/SyncArticleImages.php

@@ -10,53 +10,34 @@ final class SyncArticleImages extends Command
 {
     protected $signature = 'lio:sync-article-images';
 
-    protected $description = 'Updates the Unsplash image for all articles';
-
-    protected $accessKey;
-
-    public function __construct()
-    {
-        parent::__construct();
-
-        $this->accessKey = config('services.unsplash.access_key');
-    }
+    protected $description = 'Updates the Unsplash image for all unsynced articles';
 
     public function handle(): void
     {
-        if (! $this->accessKey) {
+        if (! config('services.unsplash.access_key')) {
             $this->error('Unsplash access key must be configured');
 
             return;
         }
 
-        Article::published()->chunk(100, function ($articles) {
+        Article::unsyncedImages()->chunk(100, function ($articles) {
             $articles->each(function ($article) {
-                if ($this->checkShouldArticleBeSynced($article)) {
-                    $imageData = $this->fetchUnsplashImageDataFromId($article->hero_image_id);
+                $imageData = $this->fetchUnsplashImageDataFromId($article->hero_image_id);
 
-                    if (!is_null($imageData)) {
-                        $article->hero_image_url = $imageData['image_url'];
-                        $article->hero_image_author_name = $imageData['author_name'];
-                        $article->hero_image_author_url = $imageData['author_url'];
-                        $article->save();
-                    }
+                if (! is_null($imageData)) {
+                    $article->hero_image_url = $imageData['image_url'];
+                    $article->hero_image_author_name = $imageData['author_name'];
+                    $article->hero_image_author_url = $imageData['author_url'];
+                    $article->save();
                 }
             });
         });
     }
 
-    protected function checkShouldArticleBeSynced(Article $article): bool
-    {
-        if (!$article->hero_image_id || $article->hasHeroImage()) {
-            return false;
-        }
-
-        return true;
-    }
-
     protected function fetchUnsplashImageDataFromId(string $imageId): ?array
     {
-        $response = Http::retry(3, 100, null, false)->withToken($this->accessKey, 'Client-ID')
+        $response = Http::retry(3, 100, throw: false)
+            ->withToken(config('services.unsplash.access_key'), 'Client-ID')
             ->get("https://api.unsplash.com/photos/{$imageId}");
 
         if ($response->failed()) {

app/Models/Article.php

@@ -318,6 +318,12 @@ public function scopeTrending(Builder $query): Builder
             ->orderBy('submitted_at', 'desc');
     }
 
+    public function scopeUnsyncedImages(Builder $query): Builder
+    {
+        return $query->whereNotNull('hero_image_id')
+            ->whereNull('hero_image_url');
+    }
+
     public function shouldBeSearchable()
     {
         return $this->isPublished();

database/migrations/2024_09_27_095949_add_hero_image_additional_columns_to_articles.php

@@ -18,19 +18,9 @@ public function up(): void
                 $table->string('hero_image_author_url')->nullable();
             });
         });
-    }
 
-    /**
-     * Reverse the migrations.
-     */
-    public function down(): void
-    {
         Schema::table('articles', function (Blueprint $table) {
-            $table->dropColumn([
-                'hero_image_url',
-                'hero_image_author_name',
-                'hero_image_author_url',
-            ]);
+            $table->renameColumn('hero_image', 'hero_image_id');
         });
     }
 };

database/migrations/2024_10_03_065334_rename_hero_image_to_hero_image_id_in_articles.php

@@ -44,7 +44,7 @@ public function run(): void
                             [
                                 'submitted_at' => now(),
                                 'approved_at' => now(),
-                                'hero_image' => 'sxiSod0tyYQ',
+                                'hero_image_id' => 'sxiSod0tyYQ',
                             ],
                             ['submitted_at' => now(), 'approved_at' => now()],
                             ['submitted_at' => now()],

database/seeders/UserSeeder.php

@@ -86,7 +86,7 @@ class="w-full bg-center {{ $article->hasHeroImage() ? 'bg-cover' : '' }} bg-gray
                     </div>
                 </div>
 
-                @if($article->hasHeroImageAuthor())
+                @if ($article->hasHeroImageAuthor())
                     <p class="text-xs text-black/50 text-center mt-2">
                         Photo by <a class="underline font-medium" href="{{ $article->hero_image_author_url }}?ref=laravel.io" target="_blank">{{ $article->hero_image_author_name }} </a> on <a class="underline font-medium" href="https://unsplash.com/?ref=laravel.io" target="_blank">Unsplash</a>
                     </p>
@@ -256,4 +256,4 @@ class="prose prose-lg text-gray-800 prose-lio"
             @endif
         </x-modal>
     @endcan
-@endsection
+@endsection