Merge pull request #24 from e-lobo/master

assemmarwan · web-flow · commit eeb82f21fbf0 · 2020-07-27T10:46:20.000+04:00
Fix: undefined type error from upload file response
diff --git a/src/storage/frappe.socketiouploader.ts b/src/storage/frappe.socketiouploader.ts
@@ -164,7 +164,7 @@ export default class FrappeSocketIOUploader implements IErrorHandler {
   }
 
   public handleError(errorId: string, error: ErrorDetail): ErrorDetail {
-    let err = {} as ErrorDetail;
+    let err: ErrorDetail;
 
     switch (errorId) {
       case "on_complete":
@@ -300,6 +300,7 @@ export default class FrappeSocketIOUploader implements IErrorHandler {
       r = RequestResponse.success(data);
     } else {
       r = RequestResponse.fail(this.handleError("on_complete", r.error));
+      r.data = {};
       r.data.file_url = frappeUploadEnd.file_url;
     }
     this.uploadStatus.next({

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ export default class FrappeSocketIOUploader implements IErrorHandler {`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`public handleError(errorId: string, error: ErrorDetail): ErrorDetail {`
`167`		`- let err = {} as ErrorDetail;`
	`167`	`+ let err: ErrorDetail;`
`168`	`168`
`169`	`169`	`switch (errorId) {`
`170`	`170`	`case "on_complete":`
`@@ -300,6 +300,7 @@ export default class FrappeSocketIOUploader implements IErrorHandler {`
`300`	`300`	`r = RequestResponse.success(data);`
`301`	`301`	`} else {`
`302`	`302`	`r = RequestResponse.fail(this.handleError("on_complete", r.error));`
	`303`	`+ r.data = {};`
`303`	`304`	`r.data.file_url = frappeUploadEnd.file_url;`
`304`	`305`	`}`
`305`	`306`	`this.uploadStatus.next({`