fix: credential file shouldn't be world readable #1650
+19
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As has been raised in Spotifyd/spotifyd#1349 some time ago, the credential files in cache should probably not be world readable, as this allows for example other users on a multi-user system to use the Spotify account of another user.
This changes the default permissions for the file and suggests changing the permissions, if the file is world readable. One could of course just change the permissions instead of asking the user to do it, but this might be a little intrusive. If you think that the permissions should also be changed on other files / directories, let me know.
Note that this only works on Unix systems, I don't know anything about how Windows handles permissions, so didn't change anything there.