mark all MIX_Decoder_* as const.

sezero · icculus · commit b56e514a385f · 2025-09-09T20:39:45.000-04:00
diff --git a/src/SDL_mixer_internal.h b/src/SDL_mixer_internal.h
@@ -269,27 +269,28 @@ void *MIX_GetConstIOBuffer(SDL_IOStream *io, size_t *datalen);
 // Slurp in all the data from an SDL_IOStream; if it appears to be memory-based, return the pointer with no allocation or copy made.
 void *MIX_SlurpConstIO(SDL_IOStream *io, size_t *datalen, bool *copied);
 
+
 // mu-Law and a-Law lookup tables.
 extern const float MIX_alawToFloat[256];
 extern const float MIX_ulawToFloat[256];
 
 // these might not all be available, but they are all declared here as if they are.
-extern MIX_Decoder MIX_Decoder_AU;
-extern MIX_Decoder MIX_Decoder_VOC;
-extern MIX_Decoder MIX_Decoder_WAV;
-extern MIX_Decoder MIX_Decoder_AIFF;
-extern MIX_Decoder MIX_Decoder_MPG123;
-extern MIX_Decoder MIX_Decoder_DRMP3;
-extern MIX_Decoder MIX_Decoder_VORBIS;
-extern MIX_Decoder MIX_Decoder_STBVORBIS;
-extern MIX_Decoder MIX_Decoder_OPUS;
-extern MIX_Decoder MIX_Decoder_FLAC;
-extern MIX_Decoder MIX_Decoder_DRFLAC;
-extern MIX_Decoder MIX_Decoder_TIMIDITY;
-extern MIX_Decoder MIX_Decoder_FLUIDSYNTH;
-extern MIX_Decoder MIX_Decoder_WAVPACK;
-extern MIX_Decoder MIX_Decoder_GME;
-extern MIX_Decoder MIX_Decoder_XMP;
-extern MIX_Decoder MIX_Decoder_SINEWAVE;
-extern MIX_Decoder MIX_Decoder_RAW;
+extern const MIX_Decoder MIX_Decoder_AU;
+extern const MIX_Decoder MIX_Decoder_VOC;
+extern const MIX_Decoder MIX_Decoder_WAV;
+extern const MIX_Decoder MIX_Decoder_AIFF;
+extern const MIX_Decoder MIX_Decoder_MPG123;
+extern const MIX_Decoder MIX_Decoder_DRMP3;
+extern const MIX_Decoder MIX_Decoder_VORBIS;
+extern const MIX_Decoder MIX_Decoder_STBVORBIS;
+extern const MIX_Decoder MIX_Decoder_OPUS;
+extern const MIX_Decoder MIX_Decoder_FLAC;
+extern const MIX_Decoder MIX_Decoder_DRFLAC;
+extern const MIX_Decoder MIX_Decoder_TIMIDITY;
+extern const MIX_Decoder MIX_Decoder_FLUIDSYNTH;
+extern const MIX_Decoder MIX_Decoder_WAVPACK;
+extern const MIX_Decoder MIX_Decoder_GME;
+extern const MIX_Decoder MIX_Decoder_XMP;
+extern const MIX_Decoder MIX_Decoder_SINEWAVE;
+extern const MIX_Decoder MIX_Decoder_RAW;
 
diff --git a/src/decoder_aiff.c b/src/decoder_aiff.c
@@ -574,7 +574,7 @@ static void SDLCALL AIFF_quit_audio(void *audio_userdata)
     SDL_free(adata);
 }
 
-MIX_Decoder MIX_Decoder_AIFF = {
+const MIX_Decoder MIX_Decoder_AIFF = {
     "AIFF",
     NULL,  // init
     AIFF_init_audio,
diff --git a/src/decoder_au.c b/src/decoder_au.c
@@ -262,7 +262,7 @@ static void SDLCALL AU_quit_audio(void *audio_userdata)
     SDL_free(adata);
 }
 
-MIX_Decoder MIX_Decoder_AU = {
+const MIX_Decoder MIX_Decoder_AU = {
     "AU",
     NULL,  // init
     AU_init_audio,
diff --git a/src/decoder_drflac.c b/src/decoder_drflac.c
@@ -324,7 +324,7 @@ static void SDLCALL DRFLAC_quit_audio(void *audio_userdata)
     SDL_free(adata);
 }
 
-MIX_Decoder MIX_Decoder_DRFLAC = {
+const MIX_Decoder MIX_Decoder_DRFLAC = {
     "DRFLAC",
     NULL,  // init
     DRFLAC_init_audio,
diff --git a/src/decoder_drmp3.c b/src/decoder_drmp3.c
@@ -188,7 +188,7 @@ static void SDLCALL DRMP3_quit_audio(void *audio_userdata)
     SDL_free(adata);
 }
 
-MIX_Decoder MIX_Decoder_DRMP3 = {
+const MIX_Decoder MIX_Decoder_DRMP3 = {
     "DRMP3",
     NULL,  // init
     DRMP3_init_audio,
diff --git a/src/decoder_flac.c b/src/decoder_flac.c
@@ -491,7 +491,7 @@ static void SDLCALL FLAC_quit_audio(void *audio_userdata)
     SDL_free(adata);
 }
 
-MIX_Decoder MIX_Decoder_FLAC = {
+const MIX_Decoder MIX_Decoder_FLAC = {
     "FLAC",
     FLAC_init,
     FLAC_init_audio,
diff --git a/src/decoder_fluidsynth.c b/src/decoder_fluidsynth.c
@@ -365,7 +365,7 @@ static void SDLCALL FLUIDSYNTH_quit_audio(void *audio_userdata)
     SDL_free(adata);
 }
 
-MIX_Decoder MIX_Decoder_FLUIDSYNTH = {
+const MIX_Decoder MIX_Decoder_FLUIDSYNTH = {
     "FLUIDSYNTH",
     FLUIDSYNTH_init,
     FLUIDSYNTH_init_audio,
diff --git a/src/decoder_gme.c b/src/decoder_gme.c
@@ -206,7 +206,7 @@ static void SDLCALL GME_quit_audio(void *audio_userdata)
     SDL_assert(audio_userdata == NULL);  // no state.
 }
 
-MIX_Decoder MIX_Decoder_GME = {
+const MIX_Decoder MIX_Decoder_GME = {
     "GME",
     GME_init,
     GME_init_audio,
diff --git a/src/decoder_mpg123.c b/src/decoder_mpg123.c
@@ -443,7 +443,7 @@ static void SDLCALL MPG123_quit_audio(void *audio_userdata)
     SDL_assert(audio_userdata == NULL);  // no state.
 }
 
-MIX_Decoder MIX_Decoder_MPG123 = {
+const MIX_Decoder MIX_Decoder_MPG123 = {
     "MPG123",
     MPG123_init,
     MPG123_init_audio,
diff --git a/src/decoder_opus.c b/src/decoder_opus.c
@@ -345,7 +345,7 @@ static void SDLCALL OPUS_quit_audio(void *audio_userdata)
     SDL_free(adata);
 }
 
-MIX_Decoder MIX_Decoder_OPUS = {
+const MIX_Decoder MIX_Decoder_OPUS = {
     "OPUS",
     OPUS_init,
     OPUS_init_audio,
diff --git a/src/decoder_raw.c b/src/decoder_raw.c
@@ -130,7 +130,7 @@ static void SDLCALL RAW_quit_audio(void *audio_userdata)
     SDL_assert(audio_userdata == NULL);  // no state.
 }
 
-MIX_Decoder MIX_Decoder_RAW = {
+const MIX_Decoder MIX_Decoder_RAW = {
     "RAW",
     NULL,  // init
     RAW_init_audio,
diff --git a/src/decoder_sinewave.c b/src/decoder_sinewave.c
@@ -132,7 +132,7 @@ static void SDLCALL SINEWAVE_quit_audio(void *audio_userdata)
     SDL_free(audio_userdata);
 }
 
-MIX_Decoder MIX_Decoder_SINEWAVE = {
+const MIX_Decoder MIX_Decoder_SINEWAVE = {
     "SINEWAVE",
     NULL,  // init
     SINEWAVE_init_audio,
diff --git a/src/decoder_stb_vorbis.c b/src/decoder_stb_vorbis.c
@@ -342,7 +342,7 @@ static void SDLCALL STBVORBIS_quit_audio(void *audio_userdata)
     SDL_free(audio_userdata);
 }
 
-MIX_Decoder MIX_Decoder_STBVORBIS = {
+const MIX_Decoder MIX_Decoder_STBVORBIS = {
     "STBVORBIS",
     STBVORBIS_init,
     STBVORBIS_init_audio,
diff --git a/src/decoder_timidity.c b/src/decoder_timidity.c
@@ -162,7 +162,7 @@ static void SDLCALL TIMIDITY_quit_audio(void *audio_userdata)
     SDL_assert(audio_userdata == NULL);  // no state.
 }
 
-MIX_Decoder MIX_Decoder_TIMIDITY = {
+const MIX_Decoder MIX_Decoder_TIMIDITY = {
     "TIMIDITY",
     TIMIDITY_init,
     TIMIDITY_init_audio,
diff --git a/src/decoder_voc.c b/src/decoder_voc.c
@@ -583,7 +583,7 @@ static void SDLCALL VOC_quit_audio(void *audio_userdata)
     SDL_free(tdata);
 }
 
-MIX_Decoder MIX_Decoder_VOC = {
+const MIX_Decoder MIX_Decoder_VOC = {
     "VOC",
     NULL, // init
     VOC_init_audio,
diff --git a/src/decoder_vorbis.c b/src/decoder_vorbis.c
@@ -380,7 +380,7 @@ static void SDLCALL VORBIS_quit_audio(void *audio_userdata)
     SDL_free(audio_userdata);
 }
 
-MIX_Decoder MIX_Decoder_VORBIS = {
+const MIX_Decoder MIX_Decoder_VORBIS = {
     "VORBIS",
     VORBIS_init,
     VORBIS_init_audio,
diff --git a/src/decoder_wav.c b/src/decoder_wav.c
@@ -1577,7 +1577,7 @@ static void SDLCALL WAV_quit_audio(void *audio_userdata)
     SDL_free(adata);
 }
 
-MIX_Decoder MIX_Decoder_WAV = {
+const MIX_Decoder MIX_Decoder_WAV = {
     "WAV",
     NULL,  // init
     WAV_init_audio,
diff --git a/src/decoder_wavpack.c b/src/decoder_wavpack.c
@@ -617,7 +617,7 @@ static void SDLCALL WAVPACK_quit_audio(void *audio_userdata)
     SDL_free(adata);
 }
 
-MIX_Decoder MIX_Decoder_WAVPACK = {
+const MIX_Decoder MIX_Decoder_WAVPACK = {
     "WAVPACK",
     WAVPACK_init,
     WAVPACK_init_audio,
diff --git a/src/decoder_xmp.c b/src/decoder_xmp.c
@@ -284,7 +284,7 @@ static void SDLCALL XMP_quit_audio(void *audio_userdata)
     SDL_assert(audio_userdata == NULL);   // no state.
 }
 
-MIX_Decoder MIX_Decoder_XMP = {
+const MIX_Decoder MIX_Decoder_XMP = {
     "XMP",
     XMP_init,
     XMP_init_audio,

Original file line number	Diff line number	Diff line change
`@@ -574,7 +574,7 @@ static void SDLCALL AIFF_quit_audio(void *audio_userdata)`
`574`	`574`	`SDL_free(adata);`
`575`	`575`	`}`
`576`	`576`
`577`		`-MIX_Decoder MIX_Decoder_AIFF = {`
	`577`	`+const MIX_Decoder MIX_Decoder_AIFF = {`
`578`	`578`	`"AIFF",`
`579`	`579`	`NULL, // init`
`580`	`580`	`AIFF_init_audio,`
Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ static void SDLCALL AU_quit_audio(void *audio_userdata)`
`262`	`262`	`SDL_free(adata);`
`263`	`263`	`}`
`264`	`264`
`265`		`-MIX_Decoder MIX_Decoder_AU = {`
	`265`	`+const MIX_Decoder MIX_Decoder_AU = {`
`266`	`266`	`"AU",`
`267`	`267`	`NULL, // init`
`268`	`268`	`AU_init_audio,`
Original file line number	Diff line number	Diff line change
`@@ -324,7 +324,7 @@ static void SDLCALL DRFLAC_quit_audio(void *audio_userdata)`
`324`	`324`	`SDL_free(adata);`
`325`	`325`	`}`
`326`	`326`
`327`		`-MIX_Decoder MIX_Decoder_DRFLAC = {`
	`327`	`+const MIX_Decoder MIX_Decoder_DRFLAC = {`
`328`	`328`	`"DRFLAC",`
`329`	`329`	`NULL, // init`
`330`	`330`	`DRFLAC_init_audio,`
Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ static void SDLCALL DRMP3_quit_audio(void *audio_userdata)`
`188`	`188`	`SDL_free(adata);`
`189`	`189`	`}`
`190`	`190`
`191`		`-MIX_Decoder MIX_Decoder_DRMP3 = {`
	`191`	`+const MIX_Decoder MIX_Decoder_DRMP3 = {`
`192`	`192`	`"DRMP3",`
`193`	`193`	`NULL, // init`
`194`	`194`	`DRMP3_init_audio,`
Original file line number	Diff line number	Diff line change
`@@ -491,7 +491,7 @@ static void SDLCALL FLAC_quit_audio(void *audio_userdata)`
`491`	`491`	`SDL_free(adata);`
`492`	`492`	`}`
`493`	`493`
`494`		`-MIX_Decoder MIX_Decoder_FLAC = {`
	`494`	`+const MIX_Decoder MIX_Decoder_FLAC = {`
`495`	`495`	`"FLAC",`
`496`	`496`	`FLAC_init,`
`497`	`497`	`FLAC_init_audio,`
Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,7 @@ static void SDLCALL FLUIDSYNTH_quit_audio(void *audio_userdata)`
`365`	`365`	`SDL_free(adata);`
`366`	`366`	`}`
`367`	`367`
`368`		`-MIX_Decoder MIX_Decoder_FLUIDSYNTH = {`
	`368`	`+const MIX_Decoder MIX_Decoder_FLUIDSYNTH = {`
`369`	`369`	`"FLUIDSYNTH",`
`370`	`370`	`FLUIDSYNTH_init,`
`371`	`371`	`FLUIDSYNTH_init_audio,`
Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ static void SDLCALL GME_quit_audio(void *audio_userdata)`
`206`	`206`	`SDL_assert(audio_userdata == NULL); // no state.`
`207`	`207`	`}`
`208`	`208`
`209`		`-MIX_Decoder MIX_Decoder_GME = {`
	`209`	`+const MIX_Decoder MIX_Decoder_GME = {`
`210`	`210`	`"GME",`
`211`	`211`	`GME_init,`
`212`	`212`	`GME_init_audio,`
Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,7 @@ static void SDLCALL MPG123_quit_audio(void *audio_userdata)`
`443`	`443`	`SDL_assert(audio_userdata == NULL); // no state.`
`444`	`444`	`}`
`445`	`445`
`446`		`-MIX_Decoder MIX_Decoder_MPG123 = {`
	`446`	`+const MIX_Decoder MIX_Decoder_MPG123 = {`
`447`	`447`	`"MPG123",`
`448`	`448`	`MPG123_init,`
`449`	`449`	`MPG123_init_audio,`
Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,7 @@ static void SDLCALL OPUS_quit_audio(void *audio_userdata)`
`345`	`345`	`SDL_free(adata);`
`346`	`346`	`}`
`347`	`347`
`348`		`-MIX_Decoder MIX_Decoder_OPUS = {`
	`348`	`+const MIX_Decoder MIX_Decoder_OPUS = {`
`349`	`349`	`"OPUS",`
`350`	`350`	`OPUS_init,`
`351`	`351`	`OPUS_init_audio,`