Merge #360

360: Categorise every pragma r=MarinPostma a=MarinPostma

Categorise every single pragma


Co-authored-by: ad hoc <[email protected]>

Author: bors[bot]

sqld/src/query_analysis.rs

@@ -63,9 +63,7 @@ impl StmtKind {
             ) => Some(Self::Write),
             Cmd::Stmt(Stmt::Select { .. }) => Some(Self::Read),
             Cmd::Stmt(Stmt::Pragma(name, body)) => {
-                if is_ro_pragma(name, body.as_ref()) {
-                    Some(Self::Read)
-                } else if is_pragma_allowed(name, body.as_ref()) {
+                if is_pragma_allowed(name, body.as_ref()) {
                     Some(Self::Write)
                 } else {
                     None
@@ -76,20 +74,66 @@ impl StmtKind {
     }
 }
 
-fn is_ro_pragma(name: &QualifiedName, _body: Option<&PragmaBody>) -> bool {
-    matches!(name, QualifiedName {
-            db_name: None,
-            name,
-            alias: None,
-        } if name.0.starts_with("index_")|| name.0 == "encoding" || name.0 == "function_list" || name.0 == "module_list" || name.0.starts_with("table_"))
-}
+fn is_pragma_allowed(name: &QualifiedName, body: Option<&PragmaBody>) -> bool {
+    let name = name.name.0.as_str();
+    match name {
+        // always ok
+        "foreign_key" | "foreign_key_list" | "foreign_key_check" | "collation_list"
+        | "compile_options" | "data_version" | "database_list" | "freelist_count"
+        | "function_list" | "index_list" | "index_xinfo" | "integrity_check"
+        | "legacy_file_format" | "page_count" | "pragma_list" | "quick_check" | "stats" | "table_info" | "table_list" | "table_xinfo" => true,
+        // ok without args
+        "analysis_limit"
+        | "application_id"
+        | "auto_vacuum"
+        | "automatic_index"
+        | "busy_timeout"
+        | "cache_size"
+        | "cache_spill"
+        | "cell_size_check"
+        | "checkpoint_fullfsync"
+        | "defer_foreign_keys"
+        | "encoding"
+        | "fullfsync"
+        | "hard_heap_limit"
+        | "journal_mode"
+        | "journal_size_limit"
+        | "legacy_alter_table"
+        | "locking_mode"
+        | "max_page_count"
+        | "mmap_size"
+        | "page_size"
+        | "query_only"
+        | "read_uncommitted"
+        | "recursive_triggers"
+        | "reverse_unordered_selects"
+        | "schema_version"
+        | "secure_delete"
+        | "soft_heap_limit"
+        | "synchronous"
+        | "temp_store"
+        | "threads"
+        | "trusted_schema"
+        | "user_version"
+        | "wal_autocheckpoint"
+
+            if body.is_none() =>
+        {
+            true
+        }
+        // changes the state of the connection, and can't be allowed rn:
+        "case_sensitive_like" | "ignore_check_constraints" | "incremental_vacuum" 
+            // TODO: check if optimize can be safely performed
+            | "optimize"
+            | "parser_trace"
+            | "shrink_memory"
+            | "wal_checkpoint"
 
-fn is_pragma_allowed(name: &QualifiedName, _body: Option<&PragmaBody>) -> bool {
-    matches!(name, QualifiedName {
-            db_name: None,
-            name,
-            alias: None,
-        } if name.0 == "writable_schema" || name.0.starts_with("foreign_key"))
+            => {
+            false
+        }
+        _ => false,
+    }
 }
 
 /// The state of a transaction for a series of statement