Deprecate compare_testvector().

This should never have been public API.
Also introduce a `LTC_COMPARE_TESTVECTOR()` macro to be used within the
library, which doesn't exit, but only returns an error.

Signed-off-by: Steffen Jaeckel <[email protected]>

Author: sjaeckel

src/hashes/sha3_test.c

@@ -3,7 +3,6 @@
 
 /* based on https://github.com/brainhub/SHA3IUF (public domain) */
 
-#include "../../tests/common.h"
 #include "tomcrypt_private.h"
 
 #ifdef LTC_SHA3
@@ -488,61 +487,61 @@ int turbo_shake_test(void)
    /* TurboSHAKE128 on an empty buffer */
    turbo_shake_init(&c, 128);
    turbo_shake_done(&c, hash, 64);
-   COMPARE_TESTVECTOR(hash, 64, turbo_shake_128_empty, sizeof(turbo_shake_128_empty), "TurboSHAKE128", counter++);
+   LTC_COMPARE_TESTVECTOR(hash, 64, turbo_shake_128_empty, sizeof(turbo_shake_128_empty), "TurboSHAKE128", counter++);
 
    /* TurboSHAKE128 on an empty buffer, digest length 10032 bytes, test last 32 bytes */
    turbo_shake_init(&c, 128);
    for(i = 0; i != 10000 / 10; ++i){ turbo_shake_done(&c, hash, 10); }
    turbo_shake_done(&c, hash, 32);
-   COMPARE_TESTVECTOR(hash, 32, turbo_shake_128_empty_10032, sizeof(turbo_shake_128_empty_10032), "TurboSHAKE128", counter++);
+   LTC_COMPARE_TESTVECTOR(hash, 32, turbo_shake_128_empty_10032, sizeof(turbo_shake_128_empty_10032), "TurboSHAKE128", counter++);
 
    /* TurboSHAKE128 on single zero byte */
    turbo_shake_init(&c, 128);
    turbo_shake_process(&c, turbo_shake_input_single_zero, sizeof(turbo_shake_input_single_zero));
    turbo_shake_done(&c, hash, 32);
-   COMPARE_TESTVECTOR(hash, 32, turbo_shake_128_single_zero_byte, sizeof(turbo_shake_128_single_zero_byte), "TurboSHAKE128", counter++);
+   LTC_COMPARE_TESTVECTOR(hash, 32, turbo_shake_128_single_zero_byte, sizeof(turbo_shake_128_single_zero_byte), "TurboSHAKE128", counter++);
 
    /* TurboSHAKE128 on ptn(17**1) */
    turbo_shake_init(&c, 128);
    turbo_shake_process(&c, turbo_shake_input_ptn_17_pow_1, sizeof(turbo_shake_input_ptn_17_pow_1));
    turbo_shake_done(&c, hash, 32);
-   COMPARE_TESTVECTOR(hash, 32, turbo_shake_128_ptn_pow_1, sizeof(turbo_shake_128_ptn_pow_1), "TurboSHAKE128", counter++);
+   LTC_COMPARE_TESTVECTOR(hash, 32, turbo_shake_128_ptn_pow_1, sizeof(turbo_shake_128_ptn_pow_1), "TurboSHAKE128", counter++);
 
    /* TurboSHAKE128 on ptn(17**2) */
    turbo_shake_init(&c, 128);
    turbo_shake_process(&c, turbo_shake_input_ptn_17_pow_2, sizeof(turbo_shake_input_ptn_17_pow_2));
    turbo_shake_done(&c, hash, 32);
-   COMPARE_TESTVECTOR(hash, 32, turbo_shake_128_ptn_pow_2, sizeof(turbo_shake_128_ptn_pow_2), "TurboSHAKE128", counter++);
+   LTC_COMPARE_TESTVECTOR(hash, 32, turbo_shake_128_ptn_pow_2, sizeof(turbo_shake_128_ptn_pow_2), "TurboSHAKE128", counter++);
 
 
    /* TurboSHAKE256 on an empty buffer */
    turbo_shake_init(&c, 256);
    turbo_shake_done(&c, hash, 64);
-   COMPARE_TESTVECTOR(hash, 64, turbo_shake_256_empty, sizeof(turbo_shake_256_empty), "TurboSHAKE256", counter++);
+   LTC_COMPARE_TESTVECTOR(hash, 64, turbo_shake_256_empty, sizeof(turbo_shake_256_empty), "TurboSHAKE256", counter++);
 
    /* TurboSHAKE256 on an empty buffer, digest length 10032 bytes, test last 32 bytes */
    turbo_shake_init(&c, 256);
    for(i = 0; i != 10000 / 10; ++i){ turbo_shake_done(&c, hash, 10); }
    turbo_shake_done(&c, hash, 32);
-   COMPARE_TESTVECTOR(hash, 32, turbo_shake_256_empty_10032, sizeof(turbo_shake_256_empty_10032), "TurboSHAKE256", counter++);
+   LTC_COMPARE_TESTVECTOR(hash, 32, turbo_shake_256_empty_10032, sizeof(turbo_shake_256_empty_10032), "TurboSHAKE256", counter++);
 
    /* TurboSHAKE256 on single zero byte */
    turbo_shake_init(&c, 256);
    turbo_shake_process(&c, turbo_shake_input_single_zero, sizeof(turbo_shake_input_single_zero));
    turbo_shake_done(&c, hash, 64);
-   COMPARE_TESTVECTOR(hash, 64, turbo_shake_256_single_zero_byte, sizeof(turbo_shake_256_single_zero_byte), "TurboSHAKE256", counter++);
+   LTC_COMPARE_TESTVECTOR(hash, 64, turbo_shake_256_single_zero_byte, sizeof(turbo_shake_256_single_zero_byte), "TurboSHAKE256", counter++);
 
    /* TurboSHAKE256 on ptn(17**1) */
    turbo_shake_init(&c, 256);
    turbo_shake_process(&c, turbo_shake_input_ptn_17_pow_1, sizeof(turbo_shake_input_ptn_17_pow_1));
    turbo_shake_done(&c, hash, 64);
-   COMPARE_TESTVECTOR(hash, 64, turbo_shake_256_ptn_pow_1, sizeof(turbo_shake_256_ptn_pow_1), "TurboSHAKE256", counter++);
+   LTC_COMPARE_TESTVECTOR(hash, 64, turbo_shake_256_ptn_pow_1, sizeof(turbo_shake_256_ptn_pow_1), "TurboSHAKE256", counter++);
 
    /* TurboSHAKE256 on ptn(17**2) */
    turbo_shake_init(&c, 256);
    turbo_shake_process(&c, turbo_shake_input_ptn_17_pow_2, sizeof(turbo_shake_input_ptn_17_pow_2));
    turbo_shake_done(&c, hash, 64);
-   COMPARE_TESTVECTOR(hash, 64, turbo_shake_256_ptn_pow_2, sizeof(turbo_shake_256_ptn_pow_2), "TurboSHAKE256", counter++);
+   LTC_COMPARE_TESTVECTOR(hash, 64, turbo_shake_256_ptn_pow_2, sizeof(turbo_shake_256_ptn_pow_2), "TurboSHAKE256", counter++);
 
    return CRYPT_OK;
 #endif