Skip to content

Conversation

@carlaKC
Copy link
Contributor

@carlaKC carlaKC commented Nov 17, 2025

  • Remove ambiguous note about localpubkey being used in to_remote
  • While we're here, use proper htlc pubkey names in expected weights section (rather than overloading {local/remote}pubkey

As defined in the specification, our `localpubkey` is derived from
our `payment_basepoint` and the `per_commitment_point`, which means
that it changes for each commitment.

Now that we assume `option_static_remote`, we expect our counterparty
to always set their `to_remote` to use our static `payment_basepoint`
(not `localpubkey`) so that we can recover funds without knowledge of
the `per_commitment_point`.

This note contradicts that, making it seem like we're still using the
variable `localpubkey` in both the local and remote party's commitments,
not just the local one.
Use the names that we refer to earlier in the bolt.
@t-bast
Copy link
Collaborator

t-bast commented Nov 17, 2025

Remove ambiguous note about localpubkey being used in to_remote

Do you really find it ambiguous? I find it nice to highlight this symmetry between the local and remote commitment transactions, as this is one of the things that newcomers have a hard time wrapping their head around. But I may be biased since I've known this stuff for a while, if people find it confusing, happy to remove it!

@carlaKC
Copy link
Contributor Author

carlaKC commented Nov 17, 2025

Do you really find it ambiguous?

Wrote this up in the first commit message, but as I read it localpubkey is the key derived from per_commitment_point and payment_basepoint so this seems to imply that the remote party does not use a static pubkey for our to_remote output on their commit?

@t-bast
Copy link
Collaborator

t-bast commented Nov 18, 2025

Got it, that is indeed confusing now, it wasn't before static_remotekey, but now it's confusing to mix per-commitment derivation and static keys. I agree with you, thanks!

Copy link
Collaborator

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 992b7a2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants