Refactor GroupKeyReveal for multi-version support #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12179911863Details
💛 - Coveralls |
ffranr
force-pushed
the
groupkeyreveal-version-refactor
branch
from
1ecd653 to
eab05c0
Compare
guggero
approved these changes
Dec 5, 2024
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Nice and spotless rename/refactor 💯
Rename the existing `GroupKeyReveal` struct to `GroupKeyRevealV0` and introduce a new `GroupKeyReveal` interface. This change enables adding new versions of GroupKeyReveal while retaining the V0 type for proper documentation of its behavior. Support for GroupKeyReveal V0 will be preserved.
Relocate the PendingGroupWitness struct to improve code organization and readability.
Renamed the function to `GroupPubKeyV0` to allow for the introduction of future versions while maintaining clarity and compatibility.
ffranr
force-pushed
the
groupkeyreveal-version-refactor
branch
from
eab05c0 to
2fa1fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the existing
GroupKeyRevealstruct toGroupKeyRevealV0and introduce a newGroupKeyRevealinterface. This change enables adding new versions ofGroupKeyRevealwhile retaining the V0 type for proper documentation of its behavior.Support for
GroupKeyRevealV0 will be preserved.