Skip to content

Commit 5658b8a

Browse files
Merge pull request #628 from Chris53897/feature/drop-outdated-php
feat: drop support for php 7.2, 7.3
2 parents a6dc147 + bfa2233 commit 5658b8a

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,13 @@ jobs:
1010
strategy:
1111
fail-fast: false
1212
matrix:
13-
php-version: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
13+
php-version: ['7.4', '8.0', '8.1', '8.2']
1414
composer-flags: ['']
1515
symfony-version: ['^5.4']
1616
include:
17-
- php-version: 7.2
17+
- php-version: 7.4
1818
symfony-version: "^4.4"
1919
composer-flags: "--prefer-lowest"
20-
- php-version: 7.2
21-
symfony-version: "^4.4"
22-
- php-version: 7.3
23-
symfony-version: "^4.4"
2420
- php-version: 7.4
2521
symfony-version: "^4.4"
2622
- php-version: 8.0

CHANGELOG.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,15 @@
22

33
## 5.0 (to be released)
44

5-
Removed features deprecated in [4.6](#4.6)
5+
Removed features deprecated in [4.6](#46)
6+
7+
## 4.10
8+
9+
Drop support for php 7.2, 7.3
610

711
## 4.7
812

9-
Deprecations from [4.6](#4.6) will now trigger an `E_USER_DEPRECATED` deprecation
13+
Deprecations from [4.6](#46) will now trigger an `E_USER_DEPRECATED` deprecation
1014

1115
## 4.6
1216

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
}
1616
],
1717
"require": {
18-
"php": "^7.2 || ^8.0",
19-
"phpunit/phpunit": "^7.5.0 || ^8.0 || ^9.0 || ^10.0",
18+
"php": "^7.4 || ^8.0",
19+
"phpunit/phpunit": "^9.6 || ^10.0",
2020
"symfony/browser-kit": "^4.4 || ^5.1 || ^6.0",
2121
"symfony/framework-bundle": "^4.4 || ^5.1 || ^6.0"
2222
},

tests/Command/CommandTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public function testRunCommandWithoutOptionsAndNotReuseKernel(bool $useEnv): voi
111111
$this->assertStringContainsString('Verbosity level: NORMAL', $this->commandTester->getDisplay());
112112
}
113113

114-
public function useEnvProvider(): array
114+
public static function useEnvProvider(): array
115115
{
116116
return [
117117
[true],

tests/DependencyInjection/ConfigurationConfigTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ protected static function getKernelClass(): string
3636
/**
3737
* Override values to be tested.
3838
*/
39-
public function parametersProvider(): array
39+
public static function parametersProvider(): array
4040
{
4141
return [
4242
['command_verbosity', 'very_verbose'],

tests/DependencyInjection/ConfigurationTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@
1414
namespace Liip\Acme\Tests\DependencyInjection;
1515

1616
use Liip\FunctionalTestBundle\Test\WebTestCase;
17+
use Symfony\Component\DependencyInjection\ContainerInterface;
1718

1819
/**
1920
* Test default configuration.
2021
*/
2122
class ConfigurationTest extends WebTestCase
2223
{
23-
/** @var \Symfony\Component\DependencyInjection\ContainerInterface */
24-
private $clientContainer = null;
24+
private ?ContainerInterface $clientContainer = null;
2525

2626
protected function setUp(): void
2727
{
@@ -52,7 +52,7 @@ public function testParameter($node, $value): void
5252
);
5353
}
5454

55-
public function parametersProvider(): array
55+
public static function parametersProvider(): array
5656
{
5757
return [
5858
['command_verbosity', 'normal'],

0 commit comments

Comments
 (0)