navigation: Allow click event handling into an inactive pane if

that pane has no selected files.

- If there is no selection in the inactive pane, continue processing
  the event like normal. This will also 'activate' the pane for us.
- Some cleanup to use proper event-handling return values in the
  surrounding code.

Navigating between active and inactive panes (like in the
split-view mode) can be frustrating because clicking into an
inactive pane will only 'activate' it, and not select anything.
This is to preserve any existing file selection in that pane's
view.

Author: mtwebster

src/nemo-icon-view.c

@@ -2323,26 +2323,25 @@ button_press_callback (GtkWidget *widget, GdkEventFocus *event, gpointer user_da
 {
     NemoView *view = NEMO_VIEW (user_data);
     GdkEventButton *event_button = (GdkEventButton *)event;
-    int selection_count;
+    gint selection_count = nemo_view_get_selection_count (NEMO_VIEW (view));
 
-    if (!nemo_view_get_active (view)) {
+    if (!nemo_view_get_active (view) && selection_count > 0) {
         NemoWindowSlot *slot = nemo_view_get_nemo_window_slot (view);
         nemo_window_slot_make_hosting_pane_active (slot);
-        return TRUE;
+        return GDK_EVENT_STOP;
     }
 
     /* double left click on blank will go to parent folder */
     if (g_settings_get_boolean (nemo_preferences, NEMO_PREFERENCES_CLICK_DOUBLE_PARENT_FOLDER) &&
         (event_button->button == 1) && (event_button->type == GDK_2BUTTON_PRESS)) {
-        selection_count = nemo_view_get_selection_count (NEMO_VIEW (view));
         if (selection_count == 0) {
             NemoWindowSlot *slot = nemo_view_get_nemo_window_slot (view);
             nemo_window_slot_go_up (slot, 0);
-            return TRUE;
+            return GDK_EVENT_STOP;
         }
     }
 
-    return FALSE;
+    return GDK_EVENT_PROPAGATE;
 }
 
 static NemoIconContainer *

src/nemo-list-view.c

@@ -1096,7 +1096,7 @@ button_press_callback (GtkWidget *widget, GdkEventButton *event, gpointer callba
 
 	/* Don't handle extra mouse buttons here */
 	if (event->button > 5) {
-		return FALSE;
+		return GDK_EVENT_PROPAGATE;
 	}
 
     if (event->type == GDK_2BUTTON_PRESS || event->type == GDK_3BUTTON_PRESS) {
@@ -1110,17 +1110,17 @@ button_press_callback (GtkWidget *widget, GdkEventButton *event, gpointer callba
             }
         }
 
-        return TRUE;
+        return GDK_EVENT_STOP;
     }
 
 	if (event->window != gtk_tree_view_get_bin_window (tree_view)) {
-		return FALSE;
+		return GDK_EVENT_PROPAGATE;
 	}
 
-    if (!nemo_view_get_active (NEMO_VIEW (view))) {
+    if (!nemo_view_get_active (NEMO_VIEW (view)) && gtk_tree_selection_count_selected_rows (selection) > 0) {
         NemoWindowSlot *slot = nemo_view_get_nemo_window_slot (NEMO_VIEW (view));
         nemo_window_slot_make_hosting_pane_active (slot);
-        return TRUE;
+        return GDK_EVENT_STOP;
     }
 
 	nemo_list_model_set_drag_view
@@ -1280,7 +1280,7 @@ button_press_callback (GtkWidget *widget, GdkEventButton *event, gpointer callba
 
 	/* We chained to the default handler in this method, so never
 	 * let the default handler run */
-	return TRUE;
+	return GDK_EVENT_STOP;
 }
 
 static gboolean