Skip to content

Commit 8e176d0

Browse files
fix: setting up proper typecast for other variables (#210)
* setting up proper typecast for other variables * move actions to v4 as v2 is depreceated --------- Co-authored-by: SaiChand440 <[email protected]>
1 parent 5d6d558 commit 8e176d0

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

.github/workflows/native_build.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
cache: 'yarn'
2828
cache-dependency-path: '**/yarn.lock'
2929

30-
- uses: actions/cache@v2
30+
- uses: actions/cache@v4
3131
with:
3232
path: |
3333
~/.npm
@@ -63,7 +63,7 @@ jobs:
6363
cache: 'yarn'
6464
cache-dependency-path: '**/yarn.lock'
6565

66-
- uses: actions/cache@v2
66+
- uses: actions/cache@v4
6767
with:
6868
path: |
6969
~/.npm
@@ -75,7 +75,7 @@ jobs:
7575
${{ runner.os }}-node-
7676
7777
- name: Cache cocoapods
78-
uses: actions/cache@v2
78+
uses: actions/cache@v4
7979
with:
8080
path: ./ci/ios/Pods
8181
key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}

.github/workflows/test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
with:
2020
node-version: '18.x'
2121

22-
- uses: actions/cache@v2
22+
- uses: actions/cache@v4
2323
with:
2424
path: |
2525
~/.npm

ios/LiveKitReactNativeModule.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,9 +199,9 @@ public class LivekitReactNativeModule: RCTEventEmitter {
199199
@objc(createMultibandVolumeProcessor:pcId:trackId:)
200200
public func createMultibandVolumeProcessor(_ options: NSDictionary, pcId: NSNumber, trackId: String) -> String {
201201
let bands = (options["bands"] as? NSNumber)?.intValue ?? 5
202-
let minFrequency = (options["minFrequency"] as? NSString)?.floatValue ?? 1000
203-
let maxFrequency = (options["maxFrequency"] as? NSString)?.floatValue ?? 8000
204-
let intervalMs = (options["updateInterval"] as? NSString)?.floatValue ?? 40
202+
let minFrequency = (options["minFrequency"] as? NSNumber)?.floatValue ?? 1000
203+
let maxFrequency = (options["maxFrequency"] as? NSNumber)?.floatValue ?? 8000
204+
let intervalMs = (options["updateInterval"] as? NSNumber)?.floatValue ?? 40
205205

206206
let renderer = MultibandVolumeAudioRenderer(
207207
bands: bands,

0 commit comments

Comments
 (0)