Skip to content

Commit 35cc511

Browse files
committed
fixes
1 parent d49a038 commit 35cc511

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

android/src/main/java/com/oney/WebRTCModule/GetUserMediaImpl.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,22 +96,21 @@ private AudioTrack createAudioTrack(ReadableMap constraints) {
9696
MediaConstraints peerConstraints = webRTCModule.constraintsForOptions(audioConstraintsMap);
9797

9898
// Convert given constraints into the internal webrtc media constraints.
99-
// Default to on if not specified.
10099
peerConstraints.optional.add(new MediaConstraints.KeyValuePair("googAutoGainControl",
101-
audioConstraintsMap.hasKey("audioGainControl")
102-
? audioConstraintsMap.getDynamic("autoGainControl").asString()
100+
audioConstraintsMap.hasKey("autoGainControl")
101+
? ReactBridgeUtil.getMapStrValue(audioConstraintsMap, "autoGainControl")
103102
: "true"));
104103
peerConstraints.optional.add(new MediaConstraints.KeyValuePair("googNoiseSuppression",
105104
audioConstraintsMap.hasKey("noiseSuppression")
106-
? audioConstraintsMap.getDynamic("noiseSuppression").asString()
105+
? ReactBridgeUtil.getMapStrValue(audioConstraintsMap, "noiseSuppression")
107106
: "true"));
108107
peerConstraints.optional.add(new MediaConstraints.KeyValuePair("googEchoCancellation",
109108
audioConstraintsMap.hasKey("echoCancellation")
110-
? audioConstraintsMap.getDynamic("echoCancellation").asString()
109+
? ReactBridgeUtil.getMapStrValue(audioConstraintsMap, "echoCancellation")
111110
: "true"));
112111
peerConstraints.optional.add(new MediaConstraints.KeyValuePair("googHighpassFilter",
113112
audioConstraintsMap.hasKey("highpassFilter")
114-
? audioConstraintsMap.getDynamic("highpassFilter").asString()
113+
? ReactBridgeUtil.getMapStrValue(audioConstraintsMap, "highpassFilter")
115114
: "true"));
116115

117116
// PeerConnectionFactory.createAudioSource will throw an error when mandatory constraints contain nulls.

ios/RCTWebRTC/WebRTCModule+RTCMediaStream.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,16 @@ - (RTCAudioTrack *)createAudioTrack:(NSDictionary *)constraints {
4545
NSMutableDictionary *optionalConstraints = [NSMutableDictionary dictionary];
4646
optionalConstraints[@"googAutoGainControl"] = audioConstraints[@"autoGainControl"] != nil
4747
? [self convertBoolToString:audioConstraints[@"autoGainControl"]]
48-
: @"false";
48+
: @"true";
4949
optionalConstraints[@"googNoiseSuppression"] =
5050
audioConstraints[@"noiseSuppression"] != nil ? [self convertBoolToString:audioConstraints[@"noiseSuppression"]]
51-
: @"false";
51+
: @"true";
5252
optionalConstraints[@"googEchoCancellation"] =
5353
audioConstraints[@"echoCancellation"] != nil ? [self convertBoolToString:audioConstraints[@"echoCancellation"]]
54-
: @"false";
54+
: @"true";
5555
optionalConstraints[@"googHighpassFilter"] = audioConstraints[@"highpassFilter"] != nil
5656
? [self convertBoolToString:audioConstraints[@"highpassFilter"]]
57-
: @"false";
57+
: @"true";
5858

5959
RTCMediaConstraints *mediaConstraints =
6060
[[RTCMediaConstraints alloc] initWithMandatoryConstraints:nil optionalConstraints:optionalConstraints];

0 commit comments

Comments
 (0)