-
Notifications
You must be signed in to change notification settings - Fork 30
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
There is an issue in the updateIngress
function of IngressServiceClient
where the parameter validation is incorrect. If participantIdentity
is not provided, the function explicitly sets the field this.participantIdentity
to null
, causing a runtime error. Additionally, if a value is provided, it is ignored due to a logic error.
Steps to Reproduce
Steps to reproduce the behavior:
- Call
updateIngress
without providing a value forparticipantIdentity
. - Observe that
this.participantIdentity
is explicitly set tonull
, leading to a runtime error. - Call
updateIngress
with a non-nullparticipantIdentity
value. - Observe that the provided value is ignored.
Code Snippet
if (participantIdentity == null) {
this.participantIdentity = participantIdentity;
}
Expected Behavior
- If
participantIdentity
isnull
, the field should remain unchanged. - If a value is provided, it should be assigned correctly.
Actual Behavior
- The function explicitly sets
this.participantIdentity
tonull
, causing a runtime error. - Any provided value is ignored.
Suggested Fix
Change the logic to properly assign the provided parameter only when non-null value is provided.
Device Info:
- Java Version: Java 21
- LiveKit Server SDK version: 0.8.5
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working