fix: The call to the tokenizer service may be canceled in advance. #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delavet
requested review from
dannyharnik,
elevran,
kfirtoledo and
vMaroon
as code owners
delavet
force-pushed
the
fix-external-tokenizer-call
branch
from
d34fd89 to
c218520
Compare
Signed-off-by: Hang Yin <[email protected]>
delavet
force-pushed
the
fix-external-tokenizer-call
branch
from
c218520 to
15e475d
Compare
Signed-off-by: Hang Yin <[email protected]>
Signed-off-by: Hang Yin <[email protected]>
Member
|
/lgtm |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #200 .
Modify the calling method of the tokenizer service: cancel the request context only after obtaining the complete response byte array, in order to resolve the issue of occasional invocation failures of the tokenizer service.