Build fails: no member named 'ArgAndResultAttrsOpInterface' in namespace 'mlir'

[kammoh]

I'm trying to build circt from the main branch and get this error:

build/tools/circt/include/circt/Dialect/SV/SV.h.inc:8517:287: error: no member named 'ArgAndResultAttrsOpInterface' in namespace 'mlir'

The build command:

cmake -G Ninja llvm/llvm -B build \
    -DCMAKE_BUILD_TYPE=Release \
    -DLLVM_ENABLE_ASSERTIONS=OFF \
    -DLLVM_TARGETS_TO_BUILD=host \
    -DLLVM_ENABLE_PROJECTS=mlir \
    -DLLVM_EXTERNAL_PROJECTS=circt \
    -DLLVM_EXTERNAL_CIRCT_SOURCE_DIR=$PWD \
    -DCIRCT_SLANG_FRONTEND_ENABLED=ON \
    -DCMAKE_EXPORT_COMPILE_COMMANDS=ON

ninja -C build

Using Apple clang version 17.0.0 (clang-1700.0.13.5).

I also tried a clean clone, making sure I had the correct llvm version checked out, but still no luck.

[seldridge]

This may be due to an out-of-date LLVM submodule. Is that perhaps stale / needs an update?

[kammoh]

I already did a git submodule update --init --recursive. My local llvm submodule is at 4913aee4, which is the same as the master branch.

[seldridge]

This is pretty weird. Your commands like identical to what is being run in CI and I haven't seen anything like this show up there. The release went out on Friday and that will do a lot of clean rebuilds. (I was thinking we hadn't observed this due to either local or remote caching.)

[uenoku]

Not reproduced locally on my end but I think CallInterface (that defines ArgAndResutAttrsOpInterface) dependency is missing in SV. #8966 hopefully fixes the issue.

[kammoh]

It still fails on my machine :(

[3333/6146] Building CXX object tools/circt/lib/Dialect/SV/CMakeFiles/obj.CIRCTSV.dir/SVOps.cpp.o
FAILED: [code=1] tools/circt/lib/Dialect/SV/CMakeFiles/obj.CIRCTSV.dir/SVOps.cpp.o
/usr/bin/c++ -DCIRCT_INCLUDE_TESTS -DGTEST_HAS_RTTI=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/Volumes/src/circt/build/tools/circt/lib/Dialect/SV -I/Volumes/src/circt/lib/Dialect/SV -I/Volumes/src/circt/build/include -I/Volumes/src/circt/llvm/llvm/include -I/Volumes/src/circt/include -I/Volumes/src/circt/build/tools/circt/include -I/opt/homebrew/include -isystem /Volumes/src/circt/llvm/llvm/../mlir/include -isystem /Volumes/src/circt/build/tools/mlir/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -O3 -DNDEBUG -std=c++17 -arch arm64 -fvisibility-inlines-hidden  -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/circt/lib/Dialect/SV/CMakeFiles/obj.CIRCTSV.dir/SVOps.cpp.o -MF tools/circt/lib/Dialect/SV/CMakeFiles/obj.CIRCTSV.dir/SVOps.cpp.o.d -o tools/circt/lib/Dialect/SV/CMakeFiles/obj.CIRCTSV.dir/SVOps.cpp.o -c /Volumes/src/circt/lib/Dialect/SV/SVOps.cpp
In file included from /Volumes/src/circt/lib/Dialect/SV/SVOps.cpp:13:
In file included from /Volumes/src/circt/include/circt/Dialect/SV/SVOps.h:201:
/Volumes/src/circt/build/tools/circt/include/circt/Dialect/SV/SV.h.inc:8517:287: error: no member named 'ArgAndResultAttrsOpInterface' in namespace 'mlir'
 8517 | class FuncCallOp : public ::mlir::Op<FuncCallOp, ::mlir::OpTrait::ZeroRegions, ::mlir::OpTrait::VariadicResults, ::mlir::OpTrait::ZeroSuccessors, ::mlir::OpTrait::VariadicOperands, ::mlir::OpTrait::OpInvariants, ::mlir::BytecodeOpInterface::Trait, ::circt::sv::NonProceduralOp, ::mlir::ArgAndResultAttrsOpInterface::Trait, ::mlir::CallOpInterface::Trait, ::mlir::SymbolUserOpInterface::Trait> {
      |                                                                                                                                                                                                                                                                                       ~~~~~~~~^

❯ git describe
firtool-1.131.0-14-g15c0a0dd4
❯ cd llvm && git status
HEAD detached at 4913aee483b
nothing to commit, working tree clean

Can we reopen the issue?

[uenoku]

Hmm, I see. Sorry about that.