Skip to content

Conversation

@luporl
Copy link
Contributor

@luporl luporl commented Sep 24, 2025

Fixes #135021

Suggested-by: Kawashima Takahiro [email protected]

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Sep 24, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 24, 2025

@llvm/pr-subscribers-clang

Author: Leandro Lupori (luporl)

Changes

Fixes #135021

Suggested-by: Kawashima Takahiro <[email protected]>


Full diff: https://github.com/llvm/llvm-project/pull/160581.diff

1 Files Affected:

  • (modified) clang/cmake/caches/Release.cmake (+1-1)
diff --git a/clang/cmake/caches/Release.cmake b/clang/cmake/caches/Release.cmake
index a523cc561b3f9..af8e341ab5f07 100644
--- a/clang/cmake/caches/Release.cmake
+++ b/clang/cmake/caches/Release.cmake
@@ -36,7 +36,7 @@ if (${CMAKE_HOST_SYSTEM_NAME} MATCHES "Linux")
   list(APPEND DEFAULT_PROJECTS "bolt")
 endif()
 
-set (DEFAULT_RUNTIMES "compiler-rt;libcxx")
+set (DEFAULT_RUNTIMES "compiler-rt;libcxx;openmp;flang-rt")
 if (NOT WIN32)
   list(APPEND DEFAULT_RUNTIMES "libcxxabi" "libunwind")
 endif()

@llvmbot llvmbot added openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime labels Oct 2, 2025
- also add a missing dependency in libompd
@luporl luporl force-pushed the luporl-release-omp branch from d94e854 to d69d257 Compare November 26, 2025 22:34
Because it is now disabled by default for projects.

Also, revert libc++ dependency fix for libompd. Since it's not
needed anymore, it's better to submit it in another PR.
@cor3ntin cor3ntin requested review from tru and tstellar November 27, 2025 14:26
@luporl
Copy link
Contributor Author

luporl commented Nov 28, 2025

About the test failures:

  • Flang :: Lower/location.f90
  • LLVM :: Object/ar-create.test
  • LLVM :: Object/archive-extract-dir.test
  • LLVM :: tools/llvm-ar/mri-addlib.test
  • LLVM :: tools/llvm-ar/mri-errors.test
  • LLVM :: tools/llvm-ar/print.test
  • libarcher :: races/critical-unrelated.c
  • libarcher :: races/lock-nested-unrelated.c
  • libarcher :: races/lock-unrelated.c
  • libarcher :: races/parallel-simple.c
  • libarcher :: races/task-dependency.c
  • libarcher :: races/task-taskgroup-unrelated.c
  • libarcher :: races/task-taskwait-nested.c
  • libarcher :: races/task-two.c
  • libarcher :: races/taskwait-depend.c
  • libarcher :: task/task_late_fulfill.c
    • The CI machine doesn't have llvm-symbolizer available in PATH, so addr2line is used instead, but the Ubuntu 22.04 version doesn't support the DWARF used in the test program:
      • addr2line: DWARF error: invalid or unhandled FORM value: 0x23
    • Possible fixes:
      • Make llvm-symbolizer available in PATH
      • Upgrade to Ubuntu 24.04
      • Modify the tests to use DWARF 3 instead of 4

The macOS builder fails to build the sanitizer tests:

ld: warning: ignoring duplicate libraries: '-lc++'
Undefined symbols for architecture arm64:
  "std::__1::__hash_memory(void const*, unsigned long)", referenced from:
  ...

It seems some object files were compiled for LLVM 22 (git) but when linking the system libc++ is used, which doesn't have std::__hash_memory, introduced in LLVM 21 IIRC.
This failure doesn't appear to be related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LLVM-20.1.0-Linux-ARM64 release is missing libomp

2 participants