[clang-tidy] False positive readability-redundant-parentheses when macro is present

[chrchr-github]

#include <algorithm>
#define min(x, y) x

int f(int a, int b) {
    return (std::min)(a, b);
}

<source>:5:12: warning: redundant parentheses around expression [readability-redundant-parentheses]
    5 |     return (std::min)(a, b);
      |            ^  

The suggested fix causes a compilation error, besides possibly changing the semantics.
https://godbolt.org/z/eE74Ws3fd

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: None (chrchr-github)

~~~c++ #include <algorithm> #define min(x, y) x

int f(int a, int b) {
return (std::min)(a, b);
}

<source>:5:12: warning: redundant parentheses around expression [readability-redundant-parentheses]
5 | return (std::min)(a, b);
| ^

The suggested fix causes a compilation error, besides possibly changing the semantics.
https://godbolt.org/z/eE74Ws3fd
</details>

[vbvictor]

CC @HerrCai0907

[HerrCai0907]

Looks like reasonable. But how could we fix it?
IMO we can only update the docs and let user to write NOLINT for this cases.

[chrchr-github]

Maybe it is advisable not to warn for (func)(arg1, arg2, ...); by default?

[HerrCai0907]

Maybe it is advisable not to warn for (func)(arg1, arg2, ...); by default?

True, maybe we can add an option to control it. I will do it this week.