Address review comments:

- Increase max node count for libcxx clusters to 32.
- Update the CPU & Memor for libcxx_runners request & limits to	suggested
  values: requests: cpu:55, memory: 200Gi; limits: cpu:32, memory: 128Gi
- Create kubernetes_secrets for	the 3 libcxx runners and add them to the
  appropriate namespaces.

Author: cmtice

premerge/gke_cluster/main.tf

@@ -73,7 +73,7 @@ resource "google_container_node_pool" "llvm_premerge_libcxx" {
 
   autoscaling {
     total_min_node_count = 0
-    total_max_node_count = 8
+    total_max_node_count = 32
   }
 
   node_config {

premerge/libcxx_runners_values.yaml

@@ -2,7 +2,7 @@ githubConfigUrl: "https://github.com/llvm"
 githubConfigSecret: "github-token"
 
 minRunners: 0
-maxRunners: 8
+maxRunners: 32
 
 runnerGroup: ${ runner_group_name }
 
@@ -39,9 +39,9 @@ template:
         #
         # We also need to request sufficient memory to not get OOM killed.
         requests:
-          cpu: 55
-          memory: "200Gi"
+          cpu: 28
+          memory: "100Gi"
         limits:
-          cpu: 64
-          memory: "256Gi"
+          cpu: 32
+          memory: "128Gi"
 

premerge/premerge_resources/main.tf

@@ -64,6 +64,57 @@ resource "kubernetes_secret" "linux_github_pat" {
   depends_on = [kubernetes_namespace.llvm_premerge_linux_runners]
 }
 
+resource "kubernetes_secret" "libcxx_github_pat" {
+  metadata {
+    name      = "github-token"
+    namespace = "llvm-premerge-libcxx-runners"
+  }
+
+  data = {
+    "github_app_id"              = var.github_app_id
+    "github_app_installation_id" = var.github_app_installation_id
+    "github_app_private_key"     = var.github_app_private_key
+  }
+
+  type = "Opaque"
+
+  depends_on = [kubernetes_namespace.llvm_premerge_libcxx_runners]
+}
+
+resource "kubernetes_secret" "libcxx_release_github_pat" {
+  metadata {
+    name      = "github-token"
+    namespace = "llvm-premerge-libcxx-release-runners"
+  }
+
+  data = {
+    "github_app_id"              = var.github_app_id
+    "github_app_installation_id" = var.github_app_installation_id
+    "github_app_private_key"     = var.github_app_private_key
+  }
+
+  type = "Opaque"
+
+  depends_on = [kubernetes_namespace.llvm_premerge_libcxx_release_runners]
+}
+
+resource "kubernetes_secret" "libcxx_next_github_pat" {
+  metadata {
+    name      = "github-token"
+    namespace = "llvm-premerge-libcxx-next-runners"
+  }
+
+  data = {
+    "github_app_id"              = var.github_app_id
+    "github_app_installation_id" = var.github_app_installation_id
+    "github_app_private_key"     = var.github_app_private_key
+  }
+
+  type = "Opaque"
+
+  depends_on = [kubernetes_namespace.llvm_premerge_libcxx_next_runners]
+}
+
 resource "kubernetes_secret" "windows_github_pat" {
   metadata {
     name      = "github-token"
@@ -143,7 +194,7 @@ resource "helm_release" "github_actions_runner_set_libcxx" {
   depends_on = [
     kubernetes_namespace.llvm_premerge_libcxx_runners,
     helm_release.github_actions_runner_controller,
-    kubernetes_secret.linux_github_pat,
+    kubernetes_secret.libcxx_github_pat,
   ]
 }
 
@@ -161,7 +212,7 @@ resource "helm_release" "github_actions_runner_set_libcxx_release" {
   depends_on = [
     kubernetes_namespace.llvm_premerge_libcxx_release_runners,
     helm_release.github_actions_runner_controller,
-    kubernetes_secret.linux_github_pat,
+    kubernetes_secret.libcxx_release_github_pat,
   ]
 }
 
@@ -179,7 +230,7 @@ resource "helm_release" "github_actions_runner_set_libcxx_next" {
   depends_on = [
     kubernetes_namespace.llvm_premerge_libcxx_next_runners,
     helm_release.github_actions_runner_controller,
-    kubernetes_secret.linux_github_pat,
+    kubernetes_secret.libcxx_next_github_pat,
   ]
 }