3094bbc broke fragments checking: InvalidBaseJoin #1574
Description
Before and after:
➜ lychee git:(87d5b56) cargo run -- ../network-documentation/services/zfs.md --include-fragments --base ../network-documentation/ --mode=emoji --timeout=5
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.87s
Running `target/debug/lychee ../network-documentation/services/zfs.md --include-fragments --base ../network-documentation/ --mode=emoji --timeout=5`
6/6 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links
🔍 6 Total (in 0s) ✅ 6 OK 🚫 0 Errors
➜ lychee git:(87d5b56) git checkout -
Previous HEAD position was 87d5b56 Box Octocrab error as it is too large (#1543)
HEAD is now at 3094bbc Add support for relative links (#1489)
➜ lychee git:(3094bbc) cargo run -- ../network-documentation/services/zfs.md --include-fragments --base ../network-documentation/ --mode=emoji --timeout=5
Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.22s
Running `target/debug/lychee ../network-documentation/services/zfs.md --include-fragments --base ../network-documentation/ --mode=emoji --timeout=5`
[WARN] Error creating request: InvalidBaseJoin("#scrubs-wichtig")
[WARN] Error creating request: InvalidBaseJoin("#unterschiedliche-platten-in-einem-vdevpool")
4/4 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links
🔍 4 Total (in 0s) ✅ 4 OK 🚫 0 Errors
You can also reproduce that with the fragments folder in this repo:
Before: cargo run -- fixtures/fragments/ --include-fragments --mode=emoji --base .
15/15 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links Issues found in 2 inputs. Find details below.
[fixtures/fragments/file1.md]:
❌ file:///Users/leanderSchulten/git_projekte/lychee/fixtures/fragments/file2.md#missing-fragment
❌ file:///Users/leanderSchulten/git_projekte/lychee/fixtures/fragments/file1.md#missing-fragment
[fixtures/fragments/file.html]:
❌ file:///Users/leanderSchulten/git_projekte/lychee/fixtures/fragments/file.html#in-the-end
🔍 15 Total (in 0s) ✅ 12 OK 🚫 3 Errors
After:
⠁ 0/0 ━━━━━━━━━━━━━━━━━━━━ Extracting links [WARN] Error creating request: InvalidBaseJoin("file1.md#lets-wear-a-hat-être")
[WARN] Error creating request: InvalidBaseJoin("#fragment-2")
[WARN] Error creating request: InvalidBaseJoin("file2.md#fragment-1")
[WARN] Error creating request: InvalidBaseJoin("#missing-fragment")
[WARN] Error creating request: InvalidBaseJoin("file2.md#missing-fragment")
[WARN] Error creating request: InvalidBaseJoin("#code-heading")
[WARN] Error creating request: InvalidBaseJoin("#explicit-fragment")
[WARN] Error creating request: InvalidBaseJoin("file.html#a-word")
[WARN] Error creating request: InvalidBaseJoin("file2.md#custom-id")
[WARN] Error creating request: InvalidBaseJoin("#kebab-case-fragment")
[WARN] Error creating request: InvalidBaseJoin("#kebab-case-fragment-1")
[WARN] Error creating request: InvalidBaseJoin("empty_file#fragment")
[WARN] Error creating request: InvalidBaseJoin("file1.md#fragment-1")
[WARN] Error creating request: InvalidBaseJoin("#in-the-beginning")
[WARN] Error creating request: InvalidBaseJoin("#in-the-end")
0/0 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links 🔍 0 Total (in 0s) ✅ 0 OK 🚫 0 Errors