Skip to content

Commit 412793e

Browse files
committed
Fix types and unit test (internal-1055)
1 parent 5e1ab95 commit 412793e

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

src/style-spec/types.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,8 @@ export type SymbolLayerSpecification = {|
424424
"text-halo-width"?: DataDrivenPropertyValueSpecification<number>,
425425
"text-halo-blur"?: DataDrivenPropertyValueSpecification<number>,
426426
"text-translate"?: PropertyValueSpecification<[number, number]>,
427-
"text-translate-anchor"?: PropertyValueSpecification<"map" | "viewport">
427+
"text-translate-anchor"?: PropertyValueSpecification<"map" | "viewport">,
428+
"icon-color-saturation"?: ExpressionSpecification
428429
|}
429430
|}
430431

src/style/terrain.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ import {Evented} from '../util/evented.js';
55
import {Properties, Transitionable, Transitioning, PossiblyEvaluated, DataConstantProperty} from './properties.js';
66

77
import EvaluationParameters from './evaluation_parameters.js';
8-
import type {Expression} from '../../src/style-spec/expression/expression.js';
9-
import type {TransitionParameters} from './properties.js';
8+
import type {ConfigOptions, TransitionParameters} from './properties.js';
109
import type {TerrainSpecification} from '../style-spec/types.js';
1110
import {ZoomDependentExpression} from '../style-spec/expression/index.js';
1211

@@ -32,7 +31,7 @@ class Terrain extends Evented {
3231
properties: PossiblyEvaluated<Props>;
3332
drapeRenderMode: number;
3433

35-
constructor(terrainOptions: TerrainSpecification, drapeRenderMode: number, scope: string, configOptions?: ?Map<string, Expression>) {
34+
constructor(terrainOptions: TerrainSpecification, drapeRenderMode: number, scope: string, configOptions?: ?ConfigOptions) {
3635
super();
3736
this.scope = scope;
3837
this._transitionable = new Transitionable(properties, configOptions);
@@ -45,7 +44,7 @@ class Terrain extends Evented {
4544
return (this._transitionable.serialize(): any);
4645
}
4746

48-
set(terrain: TerrainSpecification, configOptions?: ?Map<string, Expression>) {
47+
set(terrain: TerrainSpecification, configOptions?: ?ConfigOptions) {
4948
this._transitionable.setTransitionOrValue<TerrainSpecification>(terrain, configOptions);
5049
}
5150

test/unit/style/style_imports.test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1599,6 +1599,11 @@ test('Terrain', (t) => {
15991599
url: '/standard.json',
16001600
config: {showTerrain: true},
16011601
data: createStyleJSON({
1602+
schema: {
1603+
showTerrain: {
1604+
default: true
1605+
}
1606+
},
16021607
terrain: {source: 'mapbox-dem', exaggeration: ['case', ['config', 'showTerrain'], 2, 0]},
16031608
sources: {
16041609
'mapbox-dem': {

0 commit comments

Comments
 (0)