Skip to content

Commit 07a5e7c

Browse files
committed
add tests
1 parent b754983 commit 07a5e7c

File tree

4 files changed

+51
-8
lines changed

4 files changed

+51
-8
lines changed

kafka/record.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@ func (rb *RecordBatch) ReadFrom(d *Decoder, version int16, tag kafkaTag) error {
4444
d.reader = io.MultiReader(bytes.NewReader(b), d.reader)
4545

4646
switch magic {
47-
case 0:
48-
return rb.readFromV0(d)
49-
case 1:
47+
case 0, 1:
5048
return rb.readFromV1(d)
5149
case 2:
5250
return rb.readFromV2(d)

kafka/record_v0.go

Lines changed: 0 additions & 5 deletions
This file was deleted.

kafka/validation_test.go

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
package kafka_test
2+
3+
import (
4+
"github.com/stretchr/testify/require"
5+
"mokapi/kafka"
6+
"strings"
7+
"testing"
8+
)
9+
10+
func TestValidateTopicName(t *testing.T) {
11+
require.EqualError(t, kafka.ValidateTopicName(""), "topic name can not be empty")
12+
require.EqualError(t, kafka.ValidateTopicName("."), "topic name can not be .")
13+
require.EqualError(t, kafka.ValidateTopicName(strings.Repeat("a", 250)), "topic name can not be longer than 249")
14+
require.EqualError(t, kafka.ValidateTopicName("a$"), "topic name is not valid, valid characters are ASCII alphanumerics, '.', '_', and '-'")
15+
require.NoError(t, kafka.ValidateTopicName("a"))
16+
}

lib/http_test.go

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
package lib_test
2+
3+
import (
4+
"fmt"
5+
"github.com/stretchr/testify/require"
6+
"mokapi/lib"
7+
"net/http"
8+
"net/http/httptest"
9+
"strings"
10+
"testing"
11+
)
12+
13+
func TestGetUrl(t *testing.T) {
14+
var s *httptest.Server
15+
s = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
16+
u := lib.GetUrl(r)
17+
require.Equal(t, fmt.Sprintf("%s/foo", s.URL), u)
18+
require.True(t, strings.HasPrefix(u, "http"))
19+
}))
20+
defer s.Close()
21+
22+
_, err := s.Client().Get(s.URL + "/foo")
23+
require.NoError(t, err)
24+
25+
s = httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
26+
u := lib.GetUrl(r)
27+
require.Equal(t, fmt.Sprintf("%s/foo", s.URL), u)
28+
require.True(t, strings.HasPrefix(u, "https"))
29+
}))
30+
defer s.Close()
31+
32+
_, err = s.Client().Get(s.URL + "/foo")
33+
require.NoError(t, err)
34+
}

0 commit comments

Comments
 (0)