Skip to content

Commit 9f02dcd

Browse files
authored
ffi(bindings): added is_space to the NotificationRoomInfo (#5907)
Exposes the `is_space` flag to FFI in the `NotificationRoomInfo`, so that a client can tell through a notification if the room that generated it, is a space or not.
1 parent ab98028 commit 9f02dcd

File tree

5 files changed

+8
-0
lines changed

5 files changed

+8
-0
lines changed

bindings/matrix-sdk-ffi/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ All notable changes to this project will be documented in this file.
8484

8585
### Features
8686

87+
- Expose `is_space` in `NotificationRoomInfo`, allowing clients to determine if the room that triggered the notification is a space.
8788
- Add push actions to `NotificationItem` and replace `SyncNotification` with `NotificationItem`.
8889
([#5835](https://github.com/matrix-org/matrix-rust-sdk/pull/5835))
8990
- Add `Client::new_grant_login_with_qr_code_handler` for granting login to a new device by way of

bindings/matrix-sdk-ffi/src/client.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -967,6 +967,7 @@ impl Client {
967967
joined_members_count: room.joined_members_count(),
968968
is_encrypted: Some(room.encryption_state().is_encrypted()),
969969
is_direct,
970+
is_space: room.is_space(),
970971
};
971972

972973
listener.on_notification(

bindings/matrix-sdk-ffi/src/notification.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ pub struct NotificationRoomInfo {
3636
pub joined_members_count: u64,
3737
pub is_encrypted: Option<bool>,
3838
pub is_direct: bool,
39+
pub is_space: bool,
3940
}
4041

4142
#[derive(uniffi::Record)]
@@ -82,6 +83,7 @@ impl NotificationItem {
8283
joined_members_count: item.joined_members_count,
8384
is_encrypted: item.is_room_encrypted,
8485
is_direct: item.is_direct_message_room,
86+
is_space: item.is_space,
8587
},
8688
is_noisy: item.is_noisy,
8789
has_mention: item.has_mention,

crates/matrix-sdk-ui/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ All notable changes to this project will be documented in this file.
1010

1111
### Features
1212

13+
- Expose `is_space` in `NotificationItem`, allowing clients to determine if the room that triggered the notification is a space.
1314
- [**breaking**] The `LatestEventValue::Local` type gains 2 new fields: `sender`
1415
and `profile`.
1516
([#5885](https://github.com/matrix-org/matrix-rust-sdk/pull/5885))

crates/matrix-sdk-ui/src/notification_client.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -881,6 +881,8 @@ pub struct NotificationItem {
881881
pub is_direct_message_room: bool,
882882
/// Numbers of members who joined the room.
883883
pub joined_members_count: u64,
884+
/// Is the room a space?
885+
pub is_space: bool,
884886

885887
/// Is it a noisy notification? (i.e. does any push action contain a sound
886888
/// action)
@@ -982,6 +984,7 @@ impl NotificationItem {
982984
.map(|state| state.is_encrypted())
983985
.ok(),
984986
joined_members_count: room.joined_members_count(),
987+
is_space: room.is_space(),
985988
is_noisy,
986989
has_mention,
987990
thread_id,

0 commit comments

Comments
 (0)