fix: Don't show a syncing indicator until the sync service is started.

Author: pixlwave

crates/matrix-sdk-ui/src/room_list_service/mod.rs

@@ -386,11 +386,11 @@ impl RoomListService {
 
             loop {
                 let (sync_indicator, yield_delay) = match current_state {
-                    State::Init | State::SettingUp | State::Error { .. } => {
+                    State::SettingUp | State::Error { .. } => {
                         (SyncIndicator::Show, delay_before_showing)
                     }
 
-                    State::Recovering | State::Running | State::Terminated { .. } => {
+                    State::Init | State::Recovering | State::Running | State::Terminated { .. } => {
                         (SyncIndicator::Hide, delay_before_hiding)
                     }
                 };

crates/matrix-sdk-ui/tests/integration/room_list_service.rs

@@ -2714,10 +2714,11 @@ async fn test_sync_indicator() -> Result<(), Error> {
 
         // Request 1.
         {
-            // The state transitions into `Init`. The `SyncIndicator` must be `Show`.
+            // The state transitions into `Init`. The `SyncIndicator` stays in `Hide` as
+            // nothing is happening yet.
             assert_next_sync_indicator!(
                 sync_indicator,
-                SyncIndicator::Show,
+                SyncIndicator::Hide,
                 under DELAY_BEFORE_SHOWING + request_margin,
             );
         }
@@ -2726,7 +2727,8 @@ async fn test_sync_indicator() -> Result<(), Error> {
 
         // Request 2.
         {
-            // The state transitions into `SettingUp`. The `SyncIndicator` stays in `Show`.
+            // The state transitions into `SettingUp`. The `SyncIndicator` must be `Show` as
+            // the service has now been started.
             assert_next_sync_indicator!(
                 sync_indicator,
                 SyncIndicator::Show,