Create automation for easier to read CSP diffs #1210
Merged
+360
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhogan8
force-pushed
the
dallas/automate-headers
branch
from
64d2f65 to
c0807ce
Compare
Deploying blog-site with
|
| Latest commit: |
1408ea1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://027f68f3.blog-site-602.pages.dev |
| Branch Preview URL: | https://dallas-automate-headers.blog-site-602.pages.dev |
dhogan8
force-pushed
the
dallas/automate-headers
branch
from
c3c7976 to
9d571f3
Compare
mm-kevcenteno
requested changes
Nov 22, 2025
bin/_headers.config.ts
Outdated
| 'Content-Security-Policy': { | ||
| // Allow AJAX/fetch requests to status page, marketing site, HubSpot, and Google services | ||
| 'connect-src': [ | ||
| '\'self\'', |
Contributor
There was a problem hiding this comment.
These are still escaped
bin/_headers.config.ts
Outdated
| pattern: '/*', | ||
| headers: { | ||
| 'Content-Security-Policy': { | ||
| // Allow AJAX/fetch requests to status page, marketing site, HubSpot, and Google services |
Contributor
There was a problem hiding this comment.
Suggested change
| // Allow AJAX/fetch requests to status page, marketing site, HubSpot, and Google services |
bin/_headers.config.ts
Outdated
| 'https://www.maxmind.com', | ||
| // HubSpot API endpoint | ||
| // https://legacydocs.hubspot.com/docs/faq/how-do-i-create-a-custom-domain-for-my-forms | ||
| 'https://api.hubspot.com', |
Contributor
There was a problem hiding this comment.
The placement of comments is confusing; hubspot + google comments are grouped together but they each need to be adjacent to the relevant url(s).
Comment on lines
37
to
51
| for (const [ | ||
| header, | ||
| value, | ||
| ] of Object.entries(pathConfig.headers)) { | ||
| if (typeof value === 'object' && !Array.isArray(value)) { | ||
| // CSP-style header with directives | ||
| const directives: string[] = []; | ||
| for (const [ | ||
| directive, | ||
| sources, | ||
| ] of Object.entries(value)) { | ||
| directives.push(`${directive} ${sources.join(' ')}`); | ||
| } |
Contributor
There was a problem hiding this comment.
Indentation is weird
| /** | ||
| * Generate _headers file content from config | ||
| */ | ||
| function generateHeaders(config: { paths: PathConfig[] }): string { |
Contributor
There was a problem hiding this comment.
This is not generating the expected output. It's not outputting the proper delimiters (ie ; or ,) for non-CSP values.
Comment on lines
159
to
200
| 'Referrer-Policy': [ | ||
| 'strict-origin-when-cross-origin', | ||
| ], | ||
| 'Strict-Transport-Security': [ | ||
| 'max-age=63072000', | ||
| 'includeSubDomains', | ||
| 'preload', | ||
| ], | ||
| 'X-Content-Type-Options': [ | ||
| 'nosniff', | ||
| ], | ||
| 'X-Frame-Options': [ | ||
| 'DENY', | ||
| ], | ||
| 'X-XSS-Protection': [ | ||
| '1', | ||
| 'mode=block', | ||
| ], | ||
| }, | ||
| }, | ||
| ], |
Contributor
There was a problem hiding this comment.
Indentation is weird
dhogan8
force-pushed
the
dallas/automate-headers
branch
from
c447250 to
1408ea1
Compare
mm-kevcenteno
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.