Merge pull request #399 from viralpraxis/fix-range-edgecases-unparsing

Fix `irange`/`erange` edgecases unparsing

Author: mbj

lib/unparser/emitter/range.rb

@@ -25,9 +25,30 @@ def symbol_name
     private
 
       def dispatch
-        visit(begin_node) if begin_node
+        visit_begin_node(begin_node)
         write(TOKENS.fetch(node.type))
-        visit(end_node) if end_node
+        visit_end_node(end_node)
+      end
+
+      def visit_begin_node(node)
+        return unless node
+
+        if n_array?(begin_node)
+          writer_with(Writer::Array, node: begin_node).emit_compact
+        else
+          visit(begin_node)
+        end
+      end
+
+      def visit_end_node(node)
+        return unless node
+
+        write(' ') if n_range?(node)
+        if n_array?(node)
+          writer_with(Writer::Array, node: node).emit_compact
+        else
+          visit(node)
+        end
       end
 
     end # Range

lib/unparser/node_helpers.rb

@@ -35,6 +35,10 @@ def n_flipflop?(node)
       n_iflipflop?(node) || n_eflipflop?(node)
     end
 
+    def n_range?(node)
+      n_irange?(node) || n_erange?(node)
+    end
+
     %i[
       arg
       args
@@ -47,6 +51,7 @@ def n_flipflop?(node)
       dstr
       eflipflop
       empty_else
+      erange
       ensure
       gvar
       hash
@@ -55,6 +60,7 @@ def n_flipflop?(node)
       iflipflop
       in_pattern
       int
+      irange
       kwarg
       kwargs
       kwsplat

test/corpus/literal/range.rb

@@ -3,3 +3,34 @@
 (1...)
 1...2
 (..1)
+(...2)
+(..2)
+foo((1..1))
+1...2
+foo[...2]
+{ foo: ...bar }
+(1...)
+1..2
+{ foo: ..bar }
+(1..)
+1.. ..1
+1.. and 2
+1.. == 2
+1.. != 2
+1.. === 2
+1.. <=> 2
+1.. =~ 2
+1.. !~ 2
+1.. < 2
+1.. > 2
+1.. <= 2
+1.. >= 2
+1.. << 2
+1.. >> 2
+1..2
+1..-2
+1.. ..1
+1... ...1
+%i[a b]..%i[c d]
+..%i[c d]
+%i[a b]..