test: add test for NonceProvider and useNonce; handle case-insensitive Set-Cookie keys (#44)

Author: mcansh

.changeset/eleven-toes-appear.md

@@ -0,0 +1,5 @@
+---
+"@mcansh/http-helmet": patch
+---
+
+explicitly handle case-insensitive Set-Cookie keys. may have already been fine, but added happy-dom to add a test for NonceProvider/useNonce and it popped up

packages/http-helmet/package.json

@@ -64,12 +64,16 @@
   },
   "devDependencies": {
     "@arethetypeswrong/cli": "catalog:",
+    "@testing-library/dom": "^10.4.0",
+    "@testing-library/jest-dom": "^6.6.3",
+    "@testing-library/react": "^16.3.0",
     "@total-typescript/tsconfig": "catalog:",
     "@types/node": "catalog:",
     "@types/react": "^19.1.8",
     "@types/react-dom": "^19.1.6",
     "@vitest/coverage-v8": "catalog:",
     "content-security-policy-parser": "^0.6.0",
+    "happy-dom": "^18.0.1",
     "react": "^19.1.0",
     "react-dom": "^19.1.0",
     "tsdown": "catalog:",

packages/http-helmet/src/index.spec.ts

@@ -211,9 +211,17 @@ describe("mergeHeaders", () => {
 
     let merged = mergeHeaders(headers1, headers2);
 
-    expect(merged.get("Set-Cookie")).toBe("foo=bar, baz=qux");
     expect(merged.getSetCookie()).toStrictEqual(["foo=bar", "baz=qux"]);
   });
+
+  it('merged different cased "Set-Cookie" headers"', () => {
+    let headers1 = new Headers({ "set-cookie": "foo=bar" });
+    let headers2 = new Headers({ "Set-Cookie": "baz=qux" });
+
+    let merged = mergeHeaders(headers1, headers2);
+
+    expect(merged.getSetCookie()).toStrictEqual(["foo=bar", "baz=qux"]);
+  })
 });
 
 it("allows mixing camel and kebab case for CSP keys", () => {

packages/http-helmet/src/react.spec.tsx

@@ -0,0 +1,24 @@
+import { render, screen } from "@testing-library/react";
+import { describe, expect, it } from "vitest";
+import { NonceProvider, useNonce } from "./react";
+
+describe("NonceProvider", () => {
+  it("pass and receive nonce", () => {
+    function Parent() {
+      return (
+        <NonceProvider nonce="test-nonce">
+          <Child />
+        </NonceProvider>
+      );
+    }
+
+    function Child() {
+      const nonce = useNonce();
+      return <div data-testid="nonce">{nonce}</div>;
+    }
+
+    render(<Parent />);
+
+    expect(screen.getByTestId("nonce")).toHaveTextContent("test-nonce");
+  });
+});

packages/http-helmet/src/utils.ts

@@ -48,9 +48,10 @@ export function mergeHeaders(...sources: HeadersInit[]): Headers {
     let headers = new Headers(source);
 
     for (let [key, value] of headers.entries()) {
+      let lowerKey = key.toLowerCase();
       if (value === undefined || value === "undefined") {
         result.delete(key);
-      } else if (key === "set-cookie") {
+      } else if (lowerKey === "set-cookie") {
         result.append(key, value);
       } else {
         result.set(key, value);

packages/http-helmet/tsconfig.json

@@ -1,10 +1,11 @@
 {
   "extends": "@total-typescript/tsconfig/bundler/dom",
-  "include": ["src/**/*"],
+  "include": ["./src/**/*", "./vitest.setup.ts"],
   "compilerOptions": {
     "allowImportingTsExtensions": true,
     "moduleResolution": "Bundler",
     "forceConsistentCasingInFileNames": true,
-    "jsx": "react-jsx"
+    "jsx": "react-jsx",
+    "types": ["vitest/globals", "@testing-library/jest-dom"]
   }
 }

packages/http-helmet/vitest.config.ts

@@ -0,0 +1,13 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+  test: {
+    setupFiles: ["./vitest.setup.ts"],
+    environment: "happy-dom",
+    coverage: {
+      provider: "v8",
+      reporter: ["text", "json", "html"],
+      include: ["./src/**/*.{ts,tsx}"],
+    },
+  },
+});

packages/http-helmet/vitest.setup.ts

@@ -0,0 +1,4 @@
+import * as matchers from "@testing-library/jest-dom/matchers";
+import { expect } from "vitest";
+
+expect.extend(matchers);

packages/url/tsconfig.json

@@ -1,9 +1,10 @@
 {
   "extends": "@total-typescript/tsconfig/bundler/dom",
-  "include": ["src/**/*"],
+  "include": ["./src/**/*"],
   "compilerOptions": {
     "allowImportingTsExtensions": true,
     "moduleResolution": "Bundler",
-    "forceConsistentCasingInFileNames": true
+    "forceConsistentCasingInFileNames": true,
+    "types": ["vitest/globals"]
   }
 }