Skip to content

Commit bf7e562

Browse files
authored
(torchx/runner)(1/n) remove useless nested event logging - runner.dryrun
Differential Revision: D82238445 Pull Request resolved: #1112
1 parent 7f4eeba commit bf7e562

File tree

1 file changed

+3
-18
lines changed

1 file changed

+3
-18
lines changed

torchx/runner/api.py

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -419,12 +419,7 @@ def dryrun(
419419
sched = self._scheduler(scheduler)
420420
resolved_cfg = sched.run_opts().resolve(cfg)
421421

422-
# early validation before build workspace
423-
with log_event(
424-
"pre_build_validate",
425-
scheduler,
426-
):
427-
sched._pre_build_validate(app, scheduler, resolved_cfg)
422+
sched._pre_build_validate(app, scheduler, resolved_cfg)
428423

429424
if workspace and isinstance(sched, WorkspaceMixin):
430425
role = app.roles[0]
@@ -434,13 +429,7 @@ def dryrun(
434429
logger.info(
435430
'To disable workspaces pass: --workspace="" from CLI or workspace=None programmatically.'
436431
)
437-
with log_event(
438-
"build_workspace_and_update_role",
439-
scheduler,
440-
) as ctx:
441-
sched.build_workspace_and_update_role(role, workspace, resolved_cfg)
442-
ctx._torchx_event.app_image = role.image
443-
ctx._torchx_event.workspace = workspace
432+
sched.build_workspace_and_update_role(role, workspace, resolved_cfg)
444433

445434
if old_img != role.image:
446435
logger.info(
@@ -453,11 +442,7 @@ def dryrun(
453442
" Either a patch was built or no changes to workspace was detected."
454443
)
455444

456-
with log_event(
457-
"validate",
458-
scheduler,
459-
):
460-
sched._validate(app, scheduler, resolved_cfg)
445+
sched._validate(app, scheduler, resolved_cfg)
461446
dryrun_info = sched.submit_dryrun(app, resolved_cfg)
462447
dryrun_info._scheduler = scheduler
463448
return dryrun_info

0 commit comments

Comments
 (0)