From 6c50a5838243b68ce753abb39a25d5e352b6d888 Mon Sep 17 00:00:00 2001 From: Kendall Garner <17521368+kgarner7@users.noreply.github.com> Date: Sun, 24 Aug 2025 19:07:56 -0700 Subject: [PATCH] fix(bpm): Only update file in callback When using the `bpm` plugin, I've observed a bug where after using this plugin, where Picard would freeze after updates. This PR apparently resolves it, by moving the `update` call into the callback instead of in the initial call --- plugins/bpm/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/bpm/__init__.py b/plugins/bpm/__init__.py index 945a00c6..1b03b076 100644 --- a/plugins/bpm/__init__.py +++ b/plugins/bpm/__init__.py @@ -73,10 +73,10 @@ def _calculate_bpm(self, file, settings): if self._close: return file.metadata["bpm"] = str(round(calculated_bpm, 1)) - file.update() def _calculate_bpm_callback(self, file, result=None, error=None): if not error: + file.update() self.tagger.window.set_statusbar_message( N_('BPM for "%(filename)s" successfully calculated.'), {'filename': file.filename}