Skip to content

Commit 768eae4

Browse files
committed
Disable node tests completely for all architectures.
1 parent 63b3dd6 commit 768eae4

File tree

1 file changed

+11
-25
lines changed

1 file changed

+11
-25
lines changed

source/metacall.scm

Lines changed: 11 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -78,33 +78,25 @@
7878
)
7979

8080
; NodeJS Loader Dependencies
81-
(define-public node-lts-386
81+
82+
; TODO: Try with version 20
83+
(define-public node-20
8284
(package/inherit node-lts
83-
(name "node-lts-386")
85+
(name "node-20")
8486
(arguments
8587
(substitute-keyword-arguments (package-arguments node-lts)
8688
((#:phases phases '%standard-phases)
8789
`(modify-phases ,phases
88-
(add-before 'delete-problematic-tests 'delete-problematic-tests-386
89-
(lambda* (#:key inputs #:allow-other-keys)
90-
;; FIXME: These tests fail in 386
91-
(for-each delete-file
92-
'("test/parallel/test-fs-utimes-y2K38.js"
93-
"test/abort/test-zlib-invalid-internals-usage.js"))))))))))
94-
95-
(define-public libnode-386
90+
(delete 'check))))))) ; Tests in 386 architecture fail on upstream
91+
92+
(define-public libnode-20
9693
(package/inherit libnode
97-
(name "libnode-386")
94+
(name "libnode-20")
9895
(arguments
9996
(substitute-keyword-arguments (package-arguments libnode)
10097
((#:phases phases '%standard-phases)
10198
`(modify-phases ,phases
102-
(add-before 'delete-problematic-tests 'delete-problematic-tests-386
103-
(lambda* (#:key inputs #:allow-other-keys)
104-
;; FIXME: These tests fail in 386
105-
(for-each delete-file
106-
'("test/parallel/test-fs-utimes-y2K38.js"
107-
"test/abort/test-zlib-invalid-internals-usage.js"))))))))))
99+
(delete 'check))))))) ; Tests in 386 architecture fail on upstream
108100

109101
(define-public espree
110102
(package
@@ -453,14 +445,8 @@ for any host, on any OS. TypeScript compiles to readable, standards-based JavaSc
453445
`(
454446
("python" ,python-3) ; Python Loader dependency
455447
("ruby" ,ruby-2.7) ; Ruby Loader dependency
456-
457-
; NodeJS Loader dependency (TODO: Fix the tests errors for 386 architecture)
458-
,@(if (target-x86?)
459-
`(("node" ,node-lts-386)
460-
("libnode" ,libnode-386))
461-
`(("node" ,node-lts)
462-
("libnode" ,libnode)))
463-
448+
("node" ,node-20) ; NodeJS Loader dependency
449+
("libnode" ,libnode-20) ; NodeJS Loader dependency
464450
("libuv" ,libuv) ; NodeJS Loader dependency
465451
("espree" ,espree) ; NodeJS Loader dependency
466452
("typescript" ,typescript) ; TypeScript Loader dependency

0 commit comments

Comments
 (0)