Skip to content

Work Graphs Coalescing Mode Intrinsics Validation is Case-Sensitive #8014

@Bloodwyn

Description

@Bloodwyn

Description
The validation of the allowed intrinsics for the "coalescing" launch mode is case-sensitive:
error: Invalid system value semantic 'SV_GroupThreadId' for launchtype 'Coalescing' const uint gtid : SV_GroupThreadId,

This is caused by this check here:

sd->SemanticName.equals("SV_GroupThreadID"))) {

Hardcoding uppcase "SV_" for the thread lauch mode might also be unintentional.

Steps to Reproduce
Use e.g. SV_GroupThreadId instead of SV_GroupThreadID in the arguments of a [NodeLaunch("coalescing")] work graphs node.

Expected Behavior
Should compile with any capitalization combination of both the words "sv_groupthreadid" and "sv_groupindex".

Fix
toLower()...

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugBug, regression, crashneeds-triageAwaiting triage

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions