move Ching-An's bug fix from experimental branch to main branch

Author: allenanie

opto/optimizers/optoprime.py

@@ -537,9 +537,12 @@ def extract_llm_suggestion(self, response: str):
 
         # if the suggested value is a code, and the entire code body is empty (i.e., not even function signature is present)
         # then we remove such suggestion
+        keys_to_remove = []
         for key, value in suggestion.items():
-            if "__code" in key and value == "":
-                del suggestion[key]
+            if "__code" in key and value.strip() == "":
+                keys_to_remove.append(key)
+        for key in keys_to_remove:
+            del suggestion[key]
 
         return suggestion
 

opto/version.py

@@ -1 +1 @@
-__version__ = "0.1.3.7"
+__version__ = "0.1.3.8"

tests/unit_tests/test_optimizer.py

@@ -150,6 +150,7 @@ def my_fun(x):
         """Test function"""
         return x**2 + 1
 
+    old_func_value = my_fun.parameter.data
 
     x = node(-1, trainable=False)
     optimizer = OptoPrime([my_fun.parameter])
@@ -163,17 +164,23 @@ def my_fun(x):
         print(p.name, p.data)
     optimizer.step(verbose=True)
 
+    new_func_value = my_fun.parameter.data
+
+    assert str(old_func_value) != str(new_func_value), "Update failed"
+    if str(old_func_value) != str(new_func_value):
+        print(f"Function failed to update: old func value: {str(new_func_value)}, new func value: {str(new_func_value)}")
+
 
     # Test directly providing feedback to parameters
     GRAPH.clear()
     x = node(-1, trainable=True)
+
     optimizer = OptoPrime([x])
     feedback = "test"
     optimizer.zero_feedback()
     optimizer.backward(x, feedback)
     optimizer.step(verbose=True)
 
-
     # Test if we can save log in both pickle and json
     import json, pickle
     json.dump(optimizer.log, open("log.json", "w"))