remove non-SAL parameters due to false positives

Author: jacob-ronstadt

src/drivers/general/queries/StrictTypeMatch/StrictTypeMatch.ql

@@ -25,43 +25,32 @@ import drivers.libraries.SAL
 from EnumConstantAccess eca, FunctionCall fc, Parameter p, int i
 where
   fc.getArgument(i) = eca and
+  not fc.getTarget().getName().matches("operator new%") and // exclude new operators
   p = fc.getTarget().getParameter(i) and
-  (
-    // check for pattern __drv_strictType(typename, mode) 
-    if p instanceof SALParameter
-    then
-    exists(string enumType1, string enumType2 | 
-      enumType1 = eca.getTarget().getDeclaringEnum().toString() and
-      enumType2 =
+  // check for pattern __drv_strictType(typename, mode)
+  p instanceof SALParameter and
+  exists(string enumType1, string enumType2 |
+    enumType1 = eca.getTarget().getDeclaringEnum().toString() and
+    enumType2 =
+      p.(SALParameter)
+          .getAnnotation()
+          .getUnexpandedArgument(0)
+          .toString()
+          .splitAt("/", _)
+          .replaceAll("enum", "")
+          .trim() and
+    not enumType2.matches("__drv_%") and // exclude other SAL annotations
+    not exists(string allowedType |
+      allowedType =
         p.(SALParameter)
             .getAnnotation()
             .getUnexpandedArgument(0)
             .toString()
             .splitAt("/", _)
             .replaceAll("enum", "")
             .trim() and
-      not enumType2.matches("__drv_%") and // exclude other SAL annotations
-      not exists(string allowedType |
-        allowedType =
-          p.(SALParameter)
-              .getAnnotation()
-              .getUnexpandedArgument(0)
-              .toString()
-              .splitAt("/", _)
-              .replaceAll("enum", "")
-              .trim() and
-        allowedType = enumType1
-      )
+      allowedType = enumType1
     )
-    else
-    // non SAL parameter
-      eca.getTarget().getDeclaringEnum().toString() !=
-        fc.getTarget()
-            .getADeclarationEntry()
-            .getParameterDeclarationEntry(i)
-            .getType()
-            .getUnderlyingType()
-            .toString()
   )
 select eca,
   "Enumerated value in a function call does not match the type specified for the parameter in the function declaration"