fix: resolve C4100 unreferenced parameter warnings across samples (#513)

qiutongMS · Qiutong Shen · web-flow · commit 081a0f44de4a · 2025-10-28T14:41:23.000+08:00
* fix: resolve C4100 unreferenced parameter warnings across samples

* set C4100 treateAsError

* move 8305 suppress to global

* extra C4100 process

* add extra test

* ext

---------

Co-authored-by: Qiutong Shen &lt;qiutongshen@microsoft.com&gt;
diff --git a/Samples/AppLifecycle/RestartRegistration/cpp-winui-packaged/S2_CrashRecovery.xaml.cpp b/Samples/AppLifecycle/RestartRegistration/cpp-winui-packaged/S2_CrashRecovery.xaml.cpp
@@ -83,7 +83,7 @@ namespace winrt::cpp_winui_packaged::implementation
         *((int*)nullptr) = 0;
     }
 
-    void S2_CrashRecovery::OnNavigatedFrom(winrt::Microsoft::UI::Xaml::Navigation::NavigationEventArgs e)
+    void S2_CrashRecovery::OnNavigatedFrom(winrt::Microsoft::UI::Xaml::Navigation::NavigationEventArgs /*e*/)
     {
         _timer.Stop();
     }
diff --git a/Samples/AppLifecycle/StateNotifications/cpp/cpp-winui-packaged/CppWinUiDesktopState/CppWinUiDesktopState/MainWindow.xaml.cpp b/Samples/AppLifecycle/StateNotifications/cpp/cpp-winui-packaged/CppWinUiDesktopState/CppWinUiDesktopState/MainWindow.xaml.cpp
@@ -61,25 +61,25 @@ void winrt::CppWinUiDesktopState::implementation::MainWindow::OutputFormattedMes
 void winrt::CppWinUiDesktopState::implementation::MainWindow::RegisterPowerManagerCallbacks()
 {
     batteryToken = PowerManager::BatteryStatusChanged([&](
-        const auto&, winrt::Windows::Foundation::IInspectable obj) { OnBatteryStatusChanged(); });
+        const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnBatteryStatusChanged(); });
     powerToken = PowerManager::PowerSupplyStatusChanged([&](
-        const auto&, winrt::Windows::Foundation::IInspectable obj) { OnPowerSupplyStatusChanged(); });
+        const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnPowerSupplyStatusChanged(); });
     powerSourceToken = PowerManager::PowerSourceKindChanged([&](
-        const auto&, winrt::Windows::Foundation::IInspectable obj) { OnPowerSourceKindChanged(); });
+        const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnPowerSourceKindChanged(); });
     chargeToken = PowerManager::RemainingChargePercentChanged([&](
-        const auto&, winrt::Windows::Foundation::IInspectable obj) { OnRemainingChargePercentChanged(); });
+        const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnRemainingChargePercentChanged(); });
     dischargeToken = PowerManager::RemainingDischargeTimeChanged([&](
-        const auto&, winrt::Windows::Foundation::IInspectable obj) { OnRemainingDischargeTimeChanged(); });
+        const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnRemainingDischargeTimeChanged(); });
     displayToken = PowerManager::DisplayStatusChanged([&](
-        const auto&, winrt::Windows::Foundation::IInspectable obj) { OnDisplayStatusChanged(); });
+        const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnDisplayStatusChanged(); });
     energyToken = PowerManager::EnergySaverStatusChanged([&](
-        const auto&, winrt::Windows::Foundation::IInspectable obj) { OnEnergySaverStatusChanged(); });
+        const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnEnergySaverStatusChanged(); });
     powerModeToken = PowerManager::EffectivePowerModeChanged([&](
-        const auto&, winrt::Windows::Foundation::IInspectable obj) { OnPowerModeChanged(); });
+        const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnPowerModeChanged(); });
     userPresenceToken = PowerManager::UserPresenceStatusChanged([&](
-        const auto&, winrt::Windows::Foundation::IInspectable obj) { OnUserPresenceStatusChanged(); });
+        const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnUserPresenceStatusChanged(); });
     systemSuspendToken = PowerManager::SystemSuspendStatusChanged([&](
-        const auto&, winrt::Windows::Foundation::IInspectable obj) { OnSystemSuspendStatusChanged(); });
+        const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnSystemSuspendStatusChanged(); });
 
     if (batteryToken && powerToken && powerSourceToken && chargeToken && dischargeToken)
     {
diff --git a/Samples/Directory.Build.props b/Samples/Directory.Build.props
@@ -1,5 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <PropertyGroup>
+    <!-- Suppress CS8305: Feature is for evaluation purposes only and is subject to change or removal in future updates. -->
+    <NoWarn>$(NoWarn);8305</NoWarn>
+  </PropertyGroup>
   <ItemDefinitionGroup>
     <ClCompile>
       <AdditionalOptions>%(AdditionalOptions) /Qspectre</AdditionalOptions>
@@ -8,6 +12,8 @@
       <!-- Setting this to be compatible with CFG -->
       <DebugInformationFormat>OldStyle</DebugInformationFormat>
       <SDLCheck>true</SDLCheck>
+      <!-- Treat C4100 (unreferenced parameter) as error -->
+      <TreatSpecificWarningsAsErrors>4100;%(TreatSpecificWarningsAsErrors)</TreatSpecificWarningsAsErrors>
     </ClCompile>
     <Link>
       <!-- dynamicbase is required for enabling CFG -->
diff --git a/Samples/Notifications/Push/cpp-console-packaged/cpp-console.cpp b/Samples/Notifications/Push/cpp-console-packaged/cpp-console.cpp
@@ -25,7 +25,7 @@ winrt::Windows::Foundation::IAsyncOperation<PushNotificationChannel> RequestChan
 
     // Setup the in-progress event handler
     channelOperation.Progress(
-        [](auto&& sender, auto&& args)
+        [](auto&& /*sender*/, auto&& args)
         {
             if (args.status == PushNotificationChannelStatus::InProgress)
             {
diff --git a/Samples/Notifications/Push/cpp-console-unpackaged/cpp-console-unpackaged.cpp b/Samples/Notifications/Push/cpp-console-unpackaged/cpp-console-unpackaged.cpp
@@ -25,7 +25,7 @@ winrt::Windows::Foundation::IAsyncOperation<PushNotificationChannel> RequestChan
 
     // Setup the in-progress event handler
     channelOperation.Progress(
-        [](auto&& sender, auto&& args)
+        [](auto&& /*sender*/, auto&& args)
         {
             if (args.status == PushNotificationChannelStatus::InProgress)
             {
diff --git a/Samples/PhotoEditor/cpp-winui/PhotoEditor/MainPage.xaml.cpp b/Samples/PhotoEditor/cpp-winui/PhotoEditor/MainPage.xaml.cpp
@@ -214,7 +214,7 @@ namespace winrt::PhotoEditor::implementation
     }
 
     // Photo clicked event handler for navigation to DetailPage view.
-    void MainPage::ImageGridView_ItemClick(IInspectable const sender, ItemClickEventArgs const e)
+    void MainPage::ImageGridView_ItemClick(IInspectable const /*sender*/, ItemClickEventArgs const e)
     {
         // Prepare the connected animation for navigation to the detail page.
         m_persistedItem = e.ClickedItem().as<PhotoEditor::Photo>();
diff --git a/Samples/TextRendering/cpp-win32/DWriteCoreGallery/ChildWindow.cpp b/Samples/TextRendering/cpp-win32/DWriteCoreGallery/ChildWindow.cpp
@@ -69,13 +69,13 @@ void ChildWindow::Move(int pixelLeft, int pixelTop, int pixelWidth, int pixelHei
     SetWindowPos(m_hwnd, nullptr, pixelLeft, pixelTop, pixelWidth, pixelHeight, SWP_SHOWWINDOW | SWP_NOZORDER | SWP_NOACTIVATE);
 }
 
-LRESULT ChildWindow::Handle_Create(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT ChildWindow::Handle_Create(HWND hwnd, UINT /*message*/, WPARAM /*wParam*/, LPARAM /*lParam*/)
 {
     m_hwnd = hwnd;
     return 0;
 }
 
-LRESULT ChildWindow::Handle_Paint(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT ChildWindow::Handle_Paint(HWND hwnd, UINT /*message*/, WPARAM /*wParam*/, LPARAM /*lParam*/)
 {
     PAINTSTRUCT ps;
     auto hdc = wil::BeginPaint(hwnd, &ps);
@@ -95,7 +95,7 @@ LRESULT ChildWindow::Handle_KeyDown(HWND hwnd, UINT message, WPARAM wParam, LPAR
     }
 }
 
-LRESULT ChildWindow::Handle_LButtonDown(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT ChildWindow::Handle_LButtonDown(HWND /*hwnd*/, UINT message, WPARAM wParam, LPARAM lParam)
 {
     // Send the message to the parent window if it's not handled by the current window.
     if (OnLeftButtonDown(GET_X_LPARAM(lParam), GET_Y_LPARAM(lParam)))
@@ -108,32 +108,32 @@ LRESULT ChildWindow::Handle_LButtonDown(HWND hwnd, UINT message, WPARAM wParam,
     }
 }
 
-LRESULT ChildWindow::Handle_LButtonUp(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT ChildWindow::Handle_LButtonUp(HWND /*hwnd*/, UINT /*message*/, WPARAM /*wParam*/, LPARAM /*lParam*/)
 {
     OnLeftButtonUp();
     return 0;
 }
 
-LRESULT ChildWindow::Handle_MouseMove(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT ChildWindow::Handle_MouseMove(HWND /*hwnd*/, UINT /*message*/, WPARAM /*wParam*/, LPARAM lParam)
 {
     OnMouseMove(GET_X_LPARAM(lParam), GET_Y_LPARAM(lParam));
     return 0;
 }
 
 
-LRESULT ChildWindow::Handle_VScroll(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT ChildWindow::Handle_VScroll(HWND /*hwnd*/, UINT /*message*/, WPARAM wParam, LPARAM /*lParam*/)
 {
     OnVSCroll(LOWORD(wParam));
     return 0;
 }
 
-LRESULT ChildWindow::Handle_MouseWheel(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT ChildWindow::Handle_MouseWheel(HWND /*hwnd*/, UINT /*message*/, WPARAM wParam, LPARAM /*lParam*/)
 {
     OnMouseWheel(static_cast<int16_t>(HIWORD(wParam)));
     return 0;
 }
 
-LRESULT ChildWindow::Handle_Size(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT ChildWindow::Handle_Size(HWND hwnd, UINT /*message*/, WPARAM /*wParam*/, LPARAM /*lParam*/)
 {
     RECT clientRect;
     GetClientRect(hwnd, &clientRect);
@@ -144,7 +144,7 @@ LRESULT ChildWindow::Handle_Size(HWND hwnd, UINT message, WPARAM wParam, LPARAM
     return 0;
 }
 
-LRESULT ChildWindow::Handle_Command(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT ChildWindow::Handle_Command(HWND /*hwnd*/, UINT /*message*/, WPARAM wParam, LPARAM lParam)
 {
     if (lParam != 0)
     {
@@ -157,13 +157,13 @@ LRESULT ChildWindow::Handle_Command(HWND hwnd, UINT message, WPARAM wParam, LPAR
     }
 }
 
-LRESULT ChildWindow::Handle_SetFocus(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT ChildWindow::Handle_SetFocus(HWND /*hwnd*/, UINT /*message*/, WPARAM /*wParam*/, LPARAM /*lParam*/)
 {
     OnFocus(true);
     return 0;
 }
 
-LRESULT ChildWindow::Handle_KillFocus(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT ChildWindow::Handle_KillFocus(HWND /*hwnd*/, UINT /*message*/, WPARAM /*wParam*/, LPARAM /*lParam*/)
 {
     OnFocus(false);
     return 0;
diff --git a/Samples/TextRendering/cpp-win32/DWriteCoreGallery/ChildWindow.h b/Samples/TextRendering/cpp-win32/DWriteCoreGallery/ChildWindow.h
@@ -36,17 +36,18 @@ class ChildWindow
 protected:
 
     // Window message handlers.
-    virtual void OnPaint(HDC hdc, RECT invalidRect) {}
-    virtual bool OnKeyDown(uint32_t keyCode) { return false; }
-    virtual bool OnLeftButtonDown(int x, int y) { return false; }
+    // Remove parameter names to avoid C4100 (unreferenced formal parameter) warnings in base implementations.
+    virtual void OnPaint(HDC /*hdc*/, RECT /*invalidRect*/) {}
+    virtual bool OnKeyDown(uint32_t /*keyCode*/) { return false; }
+    virtual bool OnLeftButtonDown(int /*x*/, int /*y*/) { return false; }
     virtual void OnLeftButtonUp() {}
-    virtual void OnMouseMove(int x, int y) {}
-    virtual void OnVSCroll(uint32_t requestId) {}
-    virtual void OnMouseWheel(int distance) {}
+    virtual void OnMouseMove(int /*x*/, int /*y*/) {}
+    virtual void OnVSCroll(uint32_t /*requestId*/) {}
+    virtual void OnMouseWheel(int /*distance*/) {}
     virtual void OnSize() {}
-    virtual void OnFocus(bool haveFocus) {}
-    virtual void OnMenuCommand(uint32_t id) {}
-    virtual LRESULT OnControlCommand(HWND controlWindow, uint32_t controlId, uint32_t notificationCode) { return 0; }
+    virtual void OnFocus(bool /*haveFocus*/) {}
+    virtual void OnMenuCommand(uint32_t /*id*/) {}
+    virtual LRESULT OnControlCommand(HWND /*controlWindow*/, uint32_t /*controlId*/, uint32_t /*notificationCode*/) { return 0; }
 
 private:
     LRESULT Handle_Create(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam);
diff --git a/Samples/TextRendering/cpp-win32/DWriteCoreGallery/FontCollectionWindow.cpp b/Samples/TextRendering/cpp-win32/DWriteCoreGallery/FontCollectionWindow.cpp
@@ -30,7 +30,7 @@ FontFaceListWindow& FontCollectionWindow::GetFaceList()
     return static_cast<FontFaceListWindow&>(*GetRightPane());
 }
 
-LRESULT FontCollectionWindow::OnControlCommand(HWND controlWindow, uint32_t controlId, uint32_t notificationCode)
+LRESULT FontCollectionWindow::OnControlCommand(HWND /*controlWindow*/, uint32_t /*controlId*/, uint32_t notificationCode)
 {
     switch (notificationCode)
     {
diff --git a/Samples/TextRendering/cpp-win32/DWriteCoreGallery/FontFaceListWindow.cpp b/Samples/TextRendering/cpp-win32/DWriteCoreGallery/FontFaceListWindow.cpp
@@ -178,7 +178,7 @@ void FontFaceListWindow::SetFontFamily(
     ListWindow::SetItemCount(fontCount);
 }
 
-void FontFaceListWindow::DrawItem(TextRenderer* textRenderer, int itemIndex, bool isSelected)
+void FontFaceListWindow::DrawItem(TextRenderer* textRenderer, int itemIndex, bool /*isSelected*/)
 {
     auto& item = m_fontItems[itemIndex];
 
diff --git a/Samples/TextRendering/cpp-win32/DWriteCoreGallery/FontFamilyListWindow.cpp b/Samples/TextRendering/cpp-win32/DWriteCoreGallery/FontFamilyListWindow.cpp
@@ -85,7 +85,7 @@ FontFamilyListWindow::FontFamilyListWindow(
     SetItemCount(familyCount);
 }
 
-void FontFamilyListWindow::DrawItem(TextRenderer* textRenderer, int itemIndex, bool isSelected)
+void FontFamilyListWindow::DrawItem(TextRenderer* textRenderer, int itemIndex, bool /*isSelected*/)
 {
     // Create the text layout object.
     auto textLayout = CreateTextLayout(m_textFormat.get(), m_familyNames[itemIndex]);
@@ -98,7 +98,7 @@ void FontFamilyListWindow::DrawItem(TextRenderer* textRenderer, int itemIndex, b
     THROW_IF_FAILED(textLayout->Draw(nullptr, textRenderer, g_leftMargin, g_topMargin));
 }
 
-int FontFamilyListWindow::GetItemPixelHeight(float dpiScale, int itemIndex)
+int FontFamilyListWindow::GetItemPixelHeight(float dpiScale, int /*itemIndex*/)
 {
     return static_cast<int>(ceilf(m_itemHeight * dpiScale));
 }
diff --git a/Samples/TextRendering/cpp-win32/DWriteCoreGallery/Helpers.cpp b/Samples/TextRendering/cpp-win32/DWriteCoreGallery/Helpers.cpp
@@ -124,14 +124,16 @@ std::wstring GetInformationalString(IDWriteFontFace6* fontFace, DWRITE_INFORMATI
 std::wstring GetFamilyName(IDWriteFontFace6* fontFace, DWRITE_FONT_FAMILY_MODEL fontFamilyModel)
 {
     wil::com_ptr<IDWriteLocalizedStrings> localizedStrings;
-    THROW_IF_FAILED(fontFace->GetFamilyNames(DWRITE_FONT_FAMILY_MODEL_TYPOGRAPHIC, &localizedStrings));
+    // Use the requested family model instead of hardcoding TYPOGRAPHIC so callers can request WSS names.
+    THROW_IF_FAILED(fontFace->GetFamilyNames(fontFamilyModel, &localizedStrings));
     return GetLocalString(localizedStrings.get());
 }
 
 std::wstring GetFaceName(IDWriteFontFace6* fontFace, DWRITE_FONT_FAMILY_MODEL fontFamilyModel)
 {
     wil::com_ptr<IDWriteLocalizedStrings> localizedStrings;
-    THROW_IF_FAILED(fontFace->GetFaceNames(DWRITE_FONT_FAMILY_MODEL_TYPOGRAPHIC, &localizedStrings));
+    // Use the requested family model when querying face names.
+    THROW_IF_FAILED(fontFace->GetFaceNames(fontFamilyModel, &localizedStrings));
     return GetLocalString(localizedStrings.get());
 }
 
diff --git a/Samples/TextRendering/cpp-win32/DWriteCoreGallery/ListWindow.cpp b/Samples/TextRendering/cpp-win32/DWriteCoreGallery/ListWindow.cpp
@@ -158,7 +158,7 @@ void ListWindow::OnPaint(HDC hdc, RECT invalidRect)
     }
 }
 
-bool ListWindow::OnLeftButtonDown(int x, int y)
+bool ListWindow::OnLeftButtonDown(int /*x*/, int y)
 {
     RECT itemRect;
     int itemIndex = ItemIndexFromY(y, &itemRect);
diff --git a/Samples/TextRendering/cpp-win32/DWriteCoreGallery/Main.cpp b/Samples/TextRendering/cpp-win32/DWriteCoreGallery/Main.cpp
@@ -18,8 +18,8 @@ _Ret_z_ WCHAR const* GetAppTitle()
 
 int APIENTRY wWinMain(
     _In_ HINSTANCE hInstance,
-    _In_opt_ HINSTANCE hPrevInstance,
-    _In_ LPWSTR lpCmdLine,
+    _In_opt_ HINSTANCE /*hPrevInstance*/,
+    _In_ LPWSTR /*lpCmdLine*/,
     _In_ int nCmdShow
 )
 {
diff --git a/Samples/TextRendering/cpp-win32/DWriteCoreGallery/MainWindow.cpp b/Samples/TextRendering/cpp-win32/DWriteCoreGallery/MainWindow.cpp
@@ -54,7 +54,7 @@ MainWindow::MainWindow(int nShowCmd)
     UpdateWindow(m_hwnd);
 }
 
-LRESULT MainWindow::OnCreate(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT MainWindow::OnCreate(HWND hwnd, UINT /*message*/, WPARAM /*wParam*/, LPARAM /*lParam*/)
 {
     m_hwnd = hwnd;
     m_textRenderer = new TextRenderer{ hwnd };
@@ -91,19 +91,19 @@ void MainWindow::SetScenario(uint32_t menuItemId)
     }
 }
 
-LRESULT MainWindow::OnSize(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT MainWindow::OnSize(HWND /*hwnd*/, UINT /*message*/, WPARAM /*wParam*/, LPARAM /*lParam*/)
 {
     ResizeScenarioWindow();
     return 0;
 }
 
-LRESULT MainWindow::OnFocus(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT MainWindow::OnFocus(HWND /*hwnd*/, UINT /*message*/, WPARAM /*wParam*/, LPARAM /*lParam*/)
 {
     SetFocus(m_activeScenarioWindow->GetHandle());
     return 0;
 }
 
-LRESULT MainWindow::OnCommand(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT MainWindow::OnCommand(HWND /*hwnd*/, UINT /*message*/, WPARAM wParam, LPARAM /*lParam*/)
 {
     uint32_t menuItemId = LOWORD(wParam);
 
@@ -120,7 +120,7 @@ LRESULT MainWindow::OnCommand(HWND hwnd, UINT message, WPARAM wParam, LPARAM lPa
     return 0;
 }
 
-LRESULT MainWindow::OnDpiChange(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+LRESULT MainWindow::OnDpiChange(HWND hwnd, UINT /*message*/, WPARAM wParam, LPARAM lParam)
 {
     UINT dpi = LOWORD(wParam);
     RECT newRect = *reinterpret_cast<RECT const*>(lParam);
diff --git a/Samples/TextRendering/cpp-win32/DWriteCoreGallery/ResourceFontFileLoader.cpp b/Samples/TextRendering/cpp-win32/DWriteCoreGallery/ResourceFontFileLoader.cpp
@@ -182,7 +182,7 @@ HRESULT STDMETHODCALLTYPE ResourceFontFileStream::ReadFileFragment(
 
 // IDWriteFontFileStream method
 void STDMETHODCALLTYPE ResourceFontFileStream::ReleaseFileFragment(
-    void* fragmentContext
+    void* /*fragmentContext*/
 ) noexcept
 {
     // The data exists for the lifetime of the module, so this is a no-op.
diff --git a/Samples/TextRendering/cpp-win32/DWriteCoreGallery/TextRenderer.cpp b/Samples/TextRendering/cpp-win32/DWriteCoreGallery/TextRenderer.cpp
diff --git a/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/CountingWidgetImpl.cpp b/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/CountingWidgetImpl.cpp
diff --git a/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WeatherWidgetImpl.cpp b/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WeatherWidgetImpl.cpp
diff --git a/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WidgetImplBase.h b/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WidgetImplBase.h
diff --git a/Samples/WindowsAIFoundry/cs-winui/WindowsAISample.csproj b/Samples/WindowsAIFoundry/cs-winui/WindowsAISample.csproj

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ namespace winrt::cpp_winui_packaged::implementation`
`83`	`83`	`((int)nullptr) = 0;`
`84`	`84`	`}`
`85`	`85`
`86`		`- void S2_CrashRecovery::OnNavigatedFrom(winrt::Microsoft::UI::Xaml::Navigation::NavigationEventArgs e)`
	`86`	`+ void S2_CrashRecovery::OnNavigatedFrom(winrt::Microsoft::UI::Xaml::Navigation::NavigationEventArgs /e/)`
`87`	`87`	`{`
`88`	`88`	`_timer.Stop();`
`89`	`89`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ winrt::Windows::Foundation::IAsyncOperation<PushNotificationChannel> RequestChan`
`25`	`25`
`26`	`26`	`// Setup the in-progress event handler`
`27`	`27`	`channelOperation.Progress(`
`28`		`- [](auto&& sender, auto&& args)`
	`28`	`+ [](auto&& /sender/, auto&& args)`
`29`	`29`	`{`
`30`	`30`	`if (args.status == PushNotificationChannelStatus::InProgress)`
`31`	`31`	`{`
Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ namespace winrt::PhotoEditor::implementation`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`// Photo clicked event handler for navigation to DetailPage view.`
`217`		`- void MainPage::ImageGridView_ItemClick(IInspectable const sender, ItemClickEventArgs const e)`
	`217`	`+ void MainPage::ImageGridView_ItemClick(IInspectable const /sender/, ItemClickEventArgs const e)`
`218`	`218`	`{`
`219`	`219`	`// Prepare the connected animation for navigation to the detail page.`
`220`	`220`	`m_persistedItem = e.ClickedItem().as<PhotoEditor::Photo>();`
Original file line number	Diff line number	Diff line change
`@@ -69,13 +69,13 @@ void ChildWindow::Move(int pixelLeft, int pixelTop, int pixelWidth, int pixelHei`
`69`	`69`	`SetWindowPos(m_hwnd, nullptr, pixelLeft, pixelTop, pixelWidth, pixelHeight, SWP_SHOWWINDOW \| SWP_NOZORDER \| SWP_NOACTIVATE);`
`70`	`70`	`}`
`71`	`71`
`72`		`-LRESULT ChildWindow::Handle_Create(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)`
	`72`	`+LRESULT ChildWindow::Handle_Create(HWND hwnd, UINT /message/, WPARAM /wParam/, LPARAM /lParam/)`
`73`	`73`	`{`
`74`	`74`	`m_hwnd = hwnd;`
`75`	`75`	`return 0;`
`76`	`76`	`}`
`77`	`77`
`78`		`-LRESULT ChildWindow::Handle_Paint(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)`
	`78`	`+LRESULT ChildWindow::Handle_Paint(HWND hwnd, UINT /message/, WPARAM /wParam/, LPARAM /lParam/)`
`79`	`79`	`{`
`80`	`80`	`PAINTSTRUCT ps;`
`81`	`81`	`auto hdc = wil::BeginPaint(hwnd, &ps);`
`@@ -95,7 +95,7 @@ LRESULT ChildWindow::Handle_KeyDown(HWND hwnd, UINT message, WPARAM wParam, LPAR`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`
`98`		`-LRESULT ChildWindow::Handle_LButtonDown(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)`
	`98`	`+LRESULT ChildWindow::Handle_LButtonDown(HWND /hwnd/, UINT message, WPARAM wParam, LPARAM lParam)`
`99`	`99`	`{`
`100`	`100`	`// Send the message to the parent window if it's not handled by the current window.`
`101`	`101`	`if (OnLeftButtonDown(GET_X_LPARAM(lParam), GET_Y_LPARAM(lParam)))`
`@@ -108,32 +108,32 @@ LRESULT ChildWindow::Handle_LButtonDown(HWND hwnd, UINT message, WPARAM wParam,`
`108`	`108`	`}`
`109`	`109`	`}`
`110`	`110`
`111`		`-LRESULT ChildWindow::Handle_LButtonUp(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)`
	`111`	`+LRESULT ChildWindow::Handle_LButtonUp(HWND /hwnd/, UINT /message/, WPARAM /wParam/, LPARAM /lParam/)`
`112`	`112`	`{`
`113`	`113`	`OnLeftButtonUp();`
`114`	`114`	`return 0;`
`115`	`115`	`}`
`116`	`116`
`117`		`-LRESULT ChildWindow::Handle_MouseMove(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)`
	`117`	`+LRESULT ChildWindow::Handle_MouseMove(HWND /hwnd/, UINT /message/, WPARAM /wParam/, LPARAM lParam)`
`118`	`118`	`{`
`119`	`119`	`OnMouseMove(GET_X_LPARAM(lParam), GET_Y_LPARAM(lParam));`
`120`	`120`	`return 0;`
`121`	`121`	`}`
`122`	`122`
`123`	`123`
`124`		`-LRESULT ChildWindow::Handle_VScroll(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)`
	`124`	`+LRESULT ChildWindow::Handle_VScroll(HWND /hwnd/, UINT /message/, WPARAM wParam, LPARAM /lParam/)`
`125`	`125`	`{`
`126`	`126`	`OnVSCroll(LOWORD(wParam));`
`127`	`127`	`return 0;`
`128`	`128`	`}`
`129`	`129`
`130`		`-LRESULT ChildWindow::Handle_MouseWheel(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)`
	`130`	`+LRESULT ChildWindow::Handle_MouseWheel(HWND /hwnd/, UINT /message/, WPARAM wParam, LPARAM /lParam/)`
`131`	`131`	`{`
`132`	`132`	`OnMouseWheel(static_cast<int16_t>(HIWORD(wParam)));`
`133`	`133`	`return 0;`
`134`	`134`	`}`
`135`	`135`
`136`		`-LRESULT ChildWindow::Handle_Size(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)`
	`136`	`+LRESULT ChildWindow::Handle_Size(HWND hwnd, UINT /message/, WPARAM /wParam/, LPARAM /lParam/)`
`137`	`137`	`{`
`138`	`138`	`RECT clientRect;`
`139`	`139`	`GetClientRect(hwnd, &clientRect);`
`@@ -144,7 +144,7 @@ LRESULT ChildWindow::Handle_Size(HWND hwnd, UINT message, WPARAM wParam, LPARAM`
`144`	`144`	`return 0;`
`145`	`145`	`}`
`146`	`146`
`147`		`-LRESULT ChildWindow::Handle_Command(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)`
	`147`	`+LRESULT ChildWindow::Handle_Command(HWND /hwnd/, UINT /message/, WPARAM wParam, LPARAM lParam)`
`148`	`148`	`{`
`149`	`149`	`if (lParam != 0)`
`150`	`150`	`{`
`@@ -157,13 +157,13 @@ LRESULT ChildWindow::Handle_Command(HWND hwnd, UINT message, WPARAM wParam, LPAR`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
`160`		`-LRESULT ChildWindow::Handle_SetFocus(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)`
	`160`	`+LRESULT ChildWindow::Handle_SetFocus(HWND /hwnd/, UINT /message/, WPARAM /wParam/, LPARAM /lParam/)`
`161`	`161`	`{`
`162`	`162`	`OnFocus(true);`
`163`	`163`	`return 0;`
`164`	`164`	`}`
`165`	`165`
`166`		`-LRESULT ChildWindow::Handle_KillFocus(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)`
	`166`	`+LRESULT ChildWindow::Handle_KillFocus(HWND /hwnd/, UINT /message/, WPARAM /wParam/, LPARAM /lParam/)`
`167`	`167`	`{`
`168`	`168`	`OnFocus(false);`
`169`	`169`	`return 0;`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ FontFaceListWindow& FontCollectionWindow::GetFaceList()`
`30`	`30`	`return static_cast<FontFaceListWindow&>(*GetRightPane());`
`31`	`31`	`}`
`32`	`32`
`33`		`-LRESULT FontCollectionWindow::OnControlCommand(HWND controlWindow, uint32_t controlId, uint32_t notificationCode)`
	`33`	`+LRESULT FontCollectionWindow::OnControlCommand(HWND /controlWindow/, uint32_t /controlId/, uint32_t notificationCode)`
`34`	`34`	`{`
`35`	`35`	`switch (notificationCode)`
`36`	`36`	`{`
Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ void FontFaceListWindow::SetFontFamily(`
`178`	`178`	`ListWindow::SetItemCount(fontCount);`
`179`	`179`	`}`
`180`	`180`
`181`		`-void FontFaceListWindow::DrawItem(TextRenderer* textRenderer, int itemIndex, bool isSelected)`
	`181`	`+void FontFaceListWindow::DrawItem(TextRenderer* textRenderer, int itemIndex, bool /isSelected/)`
`182`	`182`	`{`
`183`	`183`	`auto& item = m_fontItems[itemIndex];`
`184`	`184`