Skip to content

[Feature]: deploy to repo public websites to github pages (v9,charting,web-components) #35061

@Hotell

Description

@Hotell

Area

Tooling

Describe the feature that you would like added

we need to migrate all official repo websites deployments to live on Github Pages

Additional context

ATM we deploy on public-docsite-v9 ( react v9 storybook ) to GHP

In order to support all active domains official docsites within main branch we need to change this flow to new approach:

Following storybook builds need to be deployed to github pages:

  • public-docsite-v9
  • chart-docsite
  • web-components

Structure of deployment:

  • every domain will be deployed to sub-path
- public-docsite-v9 -> `/react`
- chart-docsite -> `/charts`
- web-components -> `/web-components`
  • these deployed sup-paths will be re-directed to sub root urls under our fluentui.dev domain
- public-docsite-v9 -> `/react` -> `react.fluentui.dev` / domain already exists
- chart-docsite -> `/charts` -> `charts.fluentui.dev` / needs setup?
- web-components -> `/web-components`-> `web-components.fluentui.dev` / domain already exists

Implementation:

  • all deployable storybook basePath will need to be adjusted to make the sub-path work as expected
  • we will encapsulate the "deploy" command/chain of commands under new deploy-website target for all the aforementioned projects
  • the GH workflow will need to be changed
    • relying on nx affected instead of relying on tj-actions/changed-files
    • the trigger will be kept ( on push to main branch / manual trigger )
    • OPTIONAL(do later) leverage GH artifacts to store NX cache so we don't re-build all 3 pages on every deploy

Execution:

  • check feasibility of sub-domain deployments to GH and if they work in separate/personal repo
  • once previous step is verified, we will implement the "new behaviour in non breaking way" in core repo
  • once verified that domain redirects work, we will remove the current public-docsite-v9 deployment step to GHP root and keep only new sub-folder deployments

💡 Implement new behaviour in non breaking way ?

We need to first test things out without breaking existing react.fluentui.dev, so we need to do following:

  1. implement the sub path deployments while keeping existing deployment

Deployment structure:

- public-docsite-v9 -> `/`  ✅ current behaviour
- public-docsite-v9 -> `/react` 🆕
- chart-docsite -> `/charts`🆕
- web-components -> `/web-components`🆕

Have you discussed this feature with our team

@microsoft/cxe-prg

Validations

  • Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

Priority

Medium

Related issues

Metadata

Metadata

Assignees

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions